Merge pull request #29 from mtrojanowski/configure_monolog

Fix archive rankings
mtrojanowski · Jun 20, 2019 · 04b40e7 · 04b40e7
2 parents ae39ca1 + 66ee1f7
commit 04b40e7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/src/Controller/RankingController.php b/src/src/Controller/RankingController.php
@@ -54,7 +54,8 @@ public function list(Request $request, string $seasonId = null) {
             );
         }
 
-        $rankingData = new RankingDataDto($ranking, new \DateTime('@'.$season->getRankingLastModified()));
+        $modificationDate = $season->getRankingLastModified() != null ? new \DateTime('@'.$season->getRankingLastModified()) : null;
+        $rankingData = new RankingDataDto($ranking, $modificationDate);
 
         return $this->json($this->getSerializer()->normalize($rankingData, 'json'));
     }

diff --git a/src/src/Controller/dto/RankingDataDto.php b/src/src/Controller/dto/RankingDataDto.php
@@ -14,7 +14,7 @@ class RankingDataDto
      * @param array $ranking
      * @param \DateTime $rankingLastModified
      */
-    public function __construct(array $ranking, \DateTime $rankingLastModified = null)
+    public function __construct(array $ranking, ?\DateTime $rankingLastModified)
     {
         $this->ranking = $ranking;
         $this->rankingLastModified = $rankingLastModified;
@@ -33,7 +33,7 @@ public function getRanking(): array
      */
     public function getRankingLastModified()
     {
-        return $this->rankingLastModified->format('Y-m-d H:i');
+        return $this->rankingLastModified != null ? $this->rankingLastModified->format('Y-m-d H:i') : "";
     }
 
 }