Implement WebSocket extension + permessage-deflate support #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrudel
force-pushed
the
websocket_deflate_extension
branch
from
51a221a
to
526bf37
Compare
mtrudel
force-pushed
the
sock_3_support
branch
from
2c6a646
to
57d6281
Compare
mtrudel
force-pushed
the
websocket_deflate_extension
branch
14 times, most recently
from
eb78df6
to
2afd80f
Compare
mtrudel
force-pushed
the
sock_3_support
branch
from
57d6281
to
e56ed16
Compare
mtrudel
force-pushed
the
websocket_deflate_extension
branch
4 times, most recently
from
87ab88e
to
ae07622
Compare
mtrudel
force-pushed
the
sock_3_support
branch
3 times, most recently
from
f3238be
to
652836d
Compare
mtrudel
force-pushed
the
websocket_deflate_extension
branch
from
ae07622
to
c20ee83
Compare
* Runs async, on dynamic port (laying ground for splitting up tests) * Output now at top-level of project * Minor code tweaks
mtrudel
force-pushed
the
websocket_deflate_extension
branch
from
c20ee83
to
5684fcc
Compare
moogle19
suggested changes
Nov 3, 2022
|
thanks for the review @moogle19 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #38, which is in turn waiting on phoenixframework/phoenix#5030 and the work therein.Ready for review. @moogle19 care to have a gander?