Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RobinDict #38

Closed
wants to merge 1 commit into from
Closed

Use RobinDict #38

wants to merge 1 commit into from

Conversation

mtsch
Copy link
Owner

@mtsch mtsch commented May 14, 2020

No description provided.

@github-actions
Copy link
Contributor

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jl

Job Properties

  • Time of benchmarks:
    • Target: 14 May 2020 - 05:37
    • Baseline: 14 May 2020 - 05:40
  • Package commits:
    • Target: d639bd
    • Baseline: b66f1a
  • Julia commits:
    • Target: 2d5741
    • Baseline: 2d5741
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["coboundary", "sparse, 25% full"] 1.06 (5%) ❌ 1.00 (1%)
["image", "helix"] 1.00 (5%) 1.03 (1%) ❌
["image", "hubble"] 1.05 (5%) ❌ 1.03 (1%) ❌
["sparse", "10 tori with 100 points, dim_max=3, modulus=2"] 1.00 (5%) 1.09 (1%) ❌
["sparse", "20 tori with 100 points, dim_max=4, modulus=2"] 1.00 (5%) 1.27 (1%) ❌
["sparse", "20 tori with 200 points, dim_max=2, modulus=3"] 1.00 (5%) 1.31 (1%) ❌
["sparse", "20 tori with 500 points, dim_max=1, modulus=3"] 0.93 (5%) ✅ 1.19 (1%) ❌
["sparse", "40 tori with 300 points, dim_max=1, modulus=2"] 0.94 (5%) ✅ 1.20 (1%) ❌
["torus", "n=256, dim_max=2, modulus=2, threshold=nothing"] 1.06 (5%) ❌ 1.13 (1%) ❌
["torus", "n=256, dim_max=2, modulus=7, threshold=1"] 1.06 (5%) ❌ 1.40 (1%) ❌
["torus", "n=64, dim_max=4, modulus=2, threshold=nothing"] 1.03 (5%) 1.04 (1%) ❌
["torus", "n=81, dim_max=4, modulus=3, threshold=1"] 1.06 (5%) ❌ 1.33 (1%) ❌

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["coboundary"]
  • ["image"]
  • ["sparse"]
  • ["torus"]

Julia versioninfo

Target

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      23447 s          0 s       2085 s       8088 s          0 s
       #2  2294 MHz       6827 s          0 s       1404 s      24791 s          0 s
       
  Memory: 6.764888763427734 GB (2725.89453125 MB free)
  Uptime: 348.0 sec
  Load Avg:  1.03857421875  0.98046875  0.50439453125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      43987 s          0 s       3053 s       8766 s          0 s
       #2  2294 MHz       7737 s          0 s       1526 s      45992 s          0 s
       
  Memory: 6.764888763427734 GB (2722.078125 MB free)
  Uptime: 571.0 sec
  Load Avg:  1.009765625  1.0  0.626953125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jl

Job Properties

  • Time of benchmark: 14 May 2020 - 5:37
  • Package commit: d639bd
  • Julia commit: 2d5741
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["coboundary", "full, no threshold"] 10.265 s (5%) 3.05 MiB (1%) 50000
["coboundary", "full, threshold=1"] 2.829 s (5%) 3.05 MiB (1%) 50000
["coboundary", "sparse, 25% full"] 5.189 s (5%) 2.44 MiB (1%) 40000
["coboundary", "sparse, 50% full"] 7.627 s (5%) 1.22 MiB (1%) 20000
["coboundary", "sparse, 75% full"] 6.672 s (5%) 625.00 KiB (1%) 10000
["image", "helix"] 13.950 s (5%) 680.025 ms 4.26 GiB (1%) 121848390
["image", "hubble"] 8.577 s (5%) 367.494 ms 2.72 GiB (1%) 77023275
["sparse", "10 tori with 100 points, dim_max=3, modulus=2"] 131.993 ms (5%) 11.68 MiB (1%) 67743
["sparse", "20 tori with 100 points, dim_max=4, modulus=2"] 11.275 s (5%) 22.142 ms 572.70 MiB (1%) 2714655
["sparse", "20 tori with 200 points, dim_max=2, modulus=3"] 2.798 s (5%) 92.89 MiB (1%) 447538
["sparse", "20 tori with 500 points, dim_max=1, modulus=3"] 3.632 s (5%) 45.95 MiB (1%) 535788
["sparse", "40 tori with 300 points, dim_max=1, modulus=2"] 10.912 s (5%) 121.36 MiB (1%) 1239023
["torus", "n=1024, dim_max=1, modulus=2, threshold=1"] 8.917 s (5%) 446.72 MiB (1%) 1705755
["torus", "n=1024, dim_max=1, modulus=7, threshold=nothing"] 13.495 s (5%) 17.192 ms 784.68 MiB (1%) 2775161
["torus", "n=256, dim_max=2, modulus=2, threshold=nothing"] 5.337 s (5%) 13.116 ms 681.79 MiB (1%) 2948949
["torus", "n=256, dim_max=2, modulus=7, threshold=1"] 2.390 s (5%) 16.237 ms 402.52 MiB (1%) 1357130
["torus", "n=64, dim_max=4, modulus=2, threshold=nothing"] 14.035 s (5%) 120.459 ms 1.99 GiB (1%) 10192051
["torus", "n=81, dim_max=4, modulus=3, threshold=1"] 12.539 s (5%) 121.814 ms 1.92 GiB (1%) 11936225

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["coboundary"]
  • ["image"]
  • ["sparse"]
  • ["torus"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      23447 s          0 s       2085 s       8088 s          0 s
       #2  2294 MHz       6827 s          0 s       1404 s      24791 s          0 s
       
  Memory: 6.764888763427734 GB (2725.89453125 MB free)
  Uptime: 348.0 sec
  Load Avg:  1.03857421875  0.98046875  0.50439453125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jl

Job Properties

  • Time of benchmark: 14 May 2020 - 5:40
  • Package commit: b66f1a
  • Julia commit: 2d5741
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["coboundary", "full, no threshold"] 9.890 s (5%) 3.05 MiB (1%) 50000
["coboundary", "full, threshold=1"] 2.751 s (5%) 3.05 MiB (1%) 50000
["coboundary", "sparse, 25% full"] 4.882 s (5%) 2.44 MiB (1%) 40000
["coboundary", "sparse, 50% full"] 7.873 s (5%) 1.22 MiB (1%) 20000
["coboundary", "sparse, 75% full"] 6.911 s (5%) 625.00 KiB (1%) 10000
["image", "helix"] 14.008 s (5%) 701.462 ms 4.15 GiB (1%) 121881501
["image", "hubble"] 8.139 s (5%) 371.058 ms 2.64 GiB (1%) 77023235
["sparse", "10 tori with 100 points, dim_max=3, modulus=2"] 131.966 ms (5%) 10.73 MiB (1%) 67683
["sparse", "20 tori with 100 points, dim_max=4, modulus=2"] 11.267 s (5%) 451.30 MiB (1%) 2727098
["sparse", "20 tori with 200 points, dim_max=2, modulus=3"] 2.802 s (5%) 71.03 MiB (1%) 447476
["sparse", "20 tori with 500 points, dim_max=1, modulus=3"] 3.894 s (5%) 38.74 MiB (1%) 535754
["sparse", "40 tori with 300 points, dim_max=1, modulus=2"] 11.639 s (5%) 101.16 MiB (1%) 1248574
["torus", "n=1024, dim_max=1, modulus=2, threshold=1"] 8.884 s (5%) 442.88 MiB (1%) 1705721
["torus", "n=1024, dim_max=1, modulus=7, threshold=nothing"] 13.415 s (5%) 16.525 ms 781.41 MiB (1%) 2789576
["torus", "n=256, dim_max=2, modulus=2, threshold=nothing"] 5.033 s (5%) 21.938 ms 601.77 MiB (1%) 2948881
["torus", "n=256, dim_max=2, modulus=7, threshold=1"] 2.252 s (5%) 14.696 ms 288.50 MiB (1%) 1357062
["torus", "n=64, dim_max=4, modulus=2, threshold=nothing"] 13.571 s (5%) 153.263 ms 1.91 GiB (1%) 10260713
["torus", "n=81, dim_max=4, modulus=3, threshold=1"] 11.792 s (5%) 68.468 ms 1.44 GiB (1%) 11840037

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["coboundary"]
  • ["image"]
  • ["sparse"]
  • ["torus"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      43987 s          0 s       3053 s       8766 s          0 s
       #2  2294 MHz       7737 s          0 s       1526 s      45992 s          0 s
       
  Memory: 6.764888763427734 GB (2722.078125 MB free)
  Uptime: 571.0 sec
  Load Avg:  1.009765625  1.0  0.626953125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               79
Model name:          Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:            1
CPU MHz:             2294.688
BogoMIPS:            4589.37
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            51200K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files          13       13           
  Lines         735      735           
=======================================
  Hits          658      658           
  Misses         77       77           
Impacted Files Coverage Δ
src/reduction_structs.jl 88.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66f1a8...a6d97d8. Read the comment docs.

@mtsch
Copy link
Owner Author

mtsch commented May 14, 2020

No improvement.

@mtsch mtsch closed this May 14, 2020
@mtsch mtsch deleted the robinhood branch May 14, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants