Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for specification version 3.17 #36

Closed
vinistock opened this issue Aug 26, 2022 · 2 comments
Closed

Update for specification version 3.17 #36

vinistock opened this issue Aug 26, 2022 · 2 comments

Comments

@vinistock
Copy link

vinistock commented Aug 26, 2022

Hello!

I've tried using generateFiles to update the gem to the latest version of the specification, since it's missing some new features (like inlay hints, pull diagnostics, etc).

However, it looks like the specification was broken down into multiple markdown files using relative references. You can see this by searching for include_relative in the raw specification markdown file.

This makes the generateFiles script miss a lot of the interfaces since they are now defined in separate files.

Any suggestions/ideas on how to handle this?

The steps I took to run generateFiles were

  • Updated the LSP version to 3.17 and the commit SHA to the most recent one
  • Changed the fetch URL to https://github.com/Microsoft/language-server-protocol/raw/${lspRepoRevision}/_specifications/lsp/${lspVersion}/specification.md, which matches the current repo structure
@mtsmfm
Copy link
Owner

mtsmfm commented Aug 27, 2022

Close via #37

I've just released 3.17.0.0. https://rubygems.org/gems/language_server-protocol/versions/3.17.0.0

@mtsmfm mtsmfm closed this as completed Aug 27, 2022
@vinistock
Copy link
Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants