Update Language Server Protocol version to 3.17 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsmfm
reviewed
Aug 27, 2022
paracycle
force-pushed
the
uk-update-lsp-3-17
branch
from
a3453b9
to
8d50818
Compare
|
Some tests were failed because of my lack of maintenance, you don't have to care about that. I'll fix them in another PR. |
mtsmfm
approved these changes
Aug 27, 2022
|
Awesome! |
|
JFYI: I didn't think this change affects benchmark though, I checked benchmark just in case and the result is same-ish. |
|
I've just released 3.17.0.0. https://rubygems.org/gems/language_server-protocol/versions/3.17.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.16, the LSP spec has changed how it stores and publishes the spec. That meant that the
generateFiles.tsscript was no longer working and needed extensive work to bring up-to-date.Fortunately, the spec is now being published as a JSON meta model file, which allows this library to drop the TS dependency and to start processing the spec using pure Ruby.
Thus, this PR, drops all Node/JS/TS dependencies and introduces a new
generate_files.rbscript to do file generation. Using that script, the PR also updates the gem to version 3.17 of the protocol spec.