Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gem package size #21

Merged
merged 1 commit into from
May 11, 2020
Merged

Reduce gem package size #21

merged 1 commit into from
May 11, 2020

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Mar 31, 2020

This pull request will reduce the gem package size by removing some files from the package.

I think removing yarn.lock will mostly reduce the size, because yarn.lock is 9.9KB.

I've confirmed this change reduced about 10KB, it is 20%.

# before this pull request
$ gem build language_server-protocol.gemspec
$ wc -c language_server-protocol-3.14.0.1.gem # it prints byte size.
45568 language_server-protocol-3.14.0.1.gem

# after this pull request
$ gem build language_server-protocol.gemspec
$ wc -c language_server-protocol-3.14.0.1.gem
35840 language_server-protocol-3.14.0.1.gem

But, I understand it will be a small impact in the real world. We have a high-speed network, so the 10KB difference can be ignored.
So if you think this change is not reasonable, feel free to close it.


By the way, this change is based on rubocop's gemspec.
https://github.com/rubocop-hq/rubocop/blob/ebae59be1d9e05bec311ce63b62b182f7a5cd118/rubocop.gemspec#L19-L20

@mtsmfm mtsmfm merged commit 97e47c5 into mtsmfm:master May 11, 2020
@mtsmfm
Copy link
Owner

mtsmfm commented May 11, 2020

@pocke Thanks!

@mtsmfm
Copy link
Owner

mtsmfm commented May 11, 2020

image

https://rubygems.org/gems/language_server-protocol

It's much smaller than before ❤️

@pocke pocke deleted the reduce-package-size branch May 11, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants