New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for logicalType #10
Comments
Good idea. Will include this in a future release. |
OK, thanks for the quick reply. I'm in a hurry so I'll go ahead and implement this for my needs. |
I'd like to think some more about how best to implement logical types, no definite ideas yet. I'm happy to review your code if you submit a pull request. For your use-case, I wonder if being able to set the schema written by the |
For my current use case that would probably be enough for now, yes |
Great, let's start with that then. And come to think of it, it would be even better to change the first argument of If you can wait until tomorrow morning, I'll get this change out then. |
Tomorrow would be great, thanks. I've made the change you suggested locally already, and it will be trivial the change the calling code again. |
Done in df20230 and released in |
works for me, thanks |
It would already be pretty useful to preserve logicalType as well as extra attributes when parsing the schema and when writing it back in a container header.
The text was updated successfully, but these errors were encountered: