Support for Azure Active Directory login in MSSQL/Tedious

[ransagy]

Would it be possible to support Azure Active Directory (password) logins in the extension?

As per the tediousjs documentation (http://tediousjs.github.io/tedious/api-connection.html), tedious and the version used by node-mssql already supports it.

Where would i look to if i wanted to add a PR for this?

[mtxr]

Hey @ransagy is possible for sure.

But I believe we already support this, it's just not documented.

Did you try to add it those options to mssqlOptions like this:

"mssqlOptions": {
  ...
  "authentication": {
    "type": "azure-active-directory-password",
    "options": {
      "userName": "<userName>",
      "password": "<password>"
    }
  },
}

[ransagy]

@mtxr You're right, it does work; but only if the password is embedded in the configuration. if i try to use "askForPassword": false and only leave the username part of that, authentication fails. In this case, the password is my Azure account pass which is a bit too sensitive to leave in the json in plaintext.

[BobbyMcWho]

@ransagy wouldn't you want "askForPassword" to be true if you're not embedding it in the json?

[ransagy]

@BobbyMcWho that's just the problem; it doesn't input the password into the specific aad password field in this case, but into the generic one, thus failing the login.

[mtxr]

@ransagy I just did a commit. I don't have a way to test it. Would you mind testing and reaching me back?

[ransagy]

@mtxr I'll try grabbing the repo and building to test, will get back to you.

[ransagy]

@mtxr confirmed working, thanks!

[mtxr]

Awesome!

…

On Sat, Sep 28, 2019, 05:09 Ran Sagy ***@***.***> wrote: @mtxr <https://github.com/mtxr> confirmed working, thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#375?email_source=notifications&email_token=AAFMX2NSUJRMVTS24EXQRILQL4GKNA5CNFSM4IVFQTX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72TSLA#issuecomment-536164652>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFMX2IDZPST3UDB3SEDSCTQL4GKNANCNFSM4IVFQTXQ> .