Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid formatting of array overlaps operator #519

Closed
mgrip opened this issue Mar 4, 2020 · 0 comments
Closed

Invalid formatting of array overlaps operator #519

mgrip opened this issue Mar 4, 2020 · 0 comments
Assignees
@mtxr
Labels
enhancement formatting pg PostgreSQL driver
Milestone
v0.22

Comments

@mgrip
Copy link

mgrip commented Mar 4, 2020 •
edited

Describe the bug
Currently the formatter converts && to & &, which is incorrect (and invalid).

https://www.postgresql.org/docs/current/functions-array.html

To Reproduce
Start with

ARRAY [1,2,3] && ARRAY [1,2]

then format, and you'll get

ARRAY [1,2,3] & & ARRAY [1,2]

Expected behavior
Not add space between &

Desktop (please complete the following information):

  • SQLTools Version 0.21.6
  • VSCode Version: 1.42.1
  • Driver Used/Version: PostgreSQL
  • OS: Mac
@mgrip mgrip added the triage label Mar 4, 2020
@mtxr mtxr added enhancement pg PostgreSQL driver labels May 11, 2020
@mtxr mtxr self-assigned this May 12, 2020
@mtxr mtxr added this to the v0.22 milestone May 12, 2020
mtxr added a commit that referenced this issue May 12, 2020
@mtxr
close #519 and #552. operators breaks issue
8f8983e
@mtxr mtxr closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtxr mtxr

Labels
enhancement formatting pg PostgreSQL driver
Projects
None yet
Milestone
v0.22
Development

No branches or pull requests
2 participants
@mtxr @mgrip