Unable to save results as CSV or JSON. EXPORT, Open Results and Save Results all broken.

[pbower]

After running a query, 'Save as CSV' or 'Save as JSON' options do not work.

Steps to reproduce the behavior:

1. Go to SQLTools and run a query.
2. Click on EXPORT, 'Open Results', or 'Save Results'
3. For EXPORT, nothing happens and no notification.
4. For Save Results/Open Results, See error

Expected behavior:
A saved CSV file or JSON file on hard drive. XLSX would be nice too, but out of scope for a fix.

Screenshot:

Desktop

• SQLTools Version 0.23.0
• VSCode Version: VSCode Version 1.58.0-insider
• OS: Ubuntu 20.04.2 LTS focal
• Driver:
  • PostgreSQL/Redshift

Additional context
It has never worked, including on older versions to my knowledge, for the last 6-12 months.

[laurenh-soa]

I am having precisely this issue with a different configuration:

• SQLTools v0.23.0
• VSCode v1.58.2 (user setup)
• OS: Windows_NT x64 10.0.18363 (Windows 10 1909)
• Driver: SQLTools Intersystems IRIS v1.1
• Database: Cache for Windows (x86-64) 2018.1.5 (Build 659U)

[dthompson-maystreet]

The offending code appears to be here:

vscode-sqltools/packages/plugins/connection-manager/language-server.ts

Line 56 in ba29476

private saveResultsHandler: RequestHandler<typeof SaveResultsRequest> = async ({ fileType, filename, ...opts }) => {

What it looks like to me is that the cache is never set; any successfully executing response should invoke the function defined at

vscode-sqltools/packages/plugins/connection-manager/cache/handlers.ts

Line 41 in 8ee200a

async function QuerySuccess(results: NSDatabase.IResult[]) {

, but this doesn't appear to happen with the extensions.

@sdissegna-maystreet, would you please take a quick look at this issue? Thank you.