Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save query #880

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Conversation

sdissegna-maystreet
Copy link
Contributor

Fixes #832, and re-enables the re-run query and export buttons.


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

@auduny auduny mentioned this pull request Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #880 (3579847) into dev (b72cf07) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 3579847 differs from pull request most recent head eb93c59. Consider uploading reports for the commit eb93c59 to get more accurate results

@@            Coverage Diff             @@
##              dev     #880      +/-   ##
==========================================
- Coverage   10.10%   10.06%   -0.05%     
==========================================
  Files         173      173              
  Lines        5797     5823      +26     
  Branches     1355     1361       +6     
==========================================
  Hits          586      586              
- Misses       5211     5237      +26     
Flag Coverage Δ
extension 10.06% <0.00%> (-0.05%) ⬇️
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/plugins/connection-manager/cache/handlers.ts 0.00% <0.00%> (ø)
...ns/connection-manager/cache/query-results.model.ts 0.00% <0.00%> (ø)
packages/plugins/connection-manager/contracts.ts 0.00% <0.00%> (ø)
packages/plugins/connection-manager/extension.ts 0.00% <0.00%> (ø)
...ages/plugins/connection-manager/language-server.ts 0.00% <0.00%> (ø)
...screens/Results/components/FooterActions/index.tsx 0.00% <0.00%> (ø)
packages/driver.mysql/src/ls/default.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@gjsjohnmurray gjsjohnmurray merged commit 3cc2ef6 into mtxr:dev Sep 1, 2022
@gjsjohnmurray gjsjohnmurray mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to save results as CSV or JSON. EXPORT, Open Results and Save Results all broken.
2 participants