Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLTools not asking to install the dependencies and not validating form with the button "Test Connection" #903

Closed
ahsand97 opened this issue May 20, 2022 · 0 comments · Fixed by #963
Closed

SQLTools not asking to install the dependencies and not validating form with the button "Test Connection" #903

ahsand97 opened this issue May 20, 2022 · 0 comments · Fixed by #963
Labels
triage

Comments

@ahsand97
Copy link

Based on this discussion basically SQLTools only asks to install extra dependencies when you click on the button "Save Connection" and then the button "Connect now", meaning that the button "Test Connection" is always gonna fail if you don't have the extra dependencies already installed or do the steps mentioned first.

Also, the button "Test Connection" doesn't do any validation on the form, all fields could be empty and u can still "test" the connection.
@gjsjohnmurray gjsjohnmurray mentioned this issue Sep 10, 2022
Merged
3 tasks
@gjsjohnmurray gjsjohnmurray linked a pull request Sep 10, 2022 that will close this issue
Install dependencies and report errors during connection test (#903) #963
Merged
3 tasks
@mtxr mtxr closed this as completed in #963 Sep 11, 2022
mtxr pushed a commit that referenced this issue Sep 11, 2022
@gjsjohnmurray
Install dependencies and report errors during connection test (#903) (#…
0576250 
…963)

* Throw informative error if connection test has no database property

* Report error from parseBeforeSave when testing a connection

* typo

* Install missing dependencies during connection test

* Pass connection test warning message properly

* remove delete of conn from error notification
See #963 (comment) for explanation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install dependencies and report errors during connection test (#903) gjsjohnmurray/vscode-sqltools
1 participant
@ahsand97