Fix errors when re-using tabs with different cols #1074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1073, tab reuse didn't work when the columns of the result changed. I've fixed this now so that no more errors are displayed. The issue was rooted in the fact that the new column widths were computed only after rendering, such that some columns were lacking a width.
Sizes of columns that have been manually resized are kept, even if the query changes.
Closes #1073.
Thank you for your contribution!
Before submitting this PR, please make sure: