Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when re-using tabs with different cols #1074

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

GeorchW
Copy link
Contributor

@GeorchW GeorchW commented Dec 30, 2022

As described in #1073, tab reuse didn't work when the columns of the result changed. I've fixed this now so that no more errors are displayed. The issue was rooted in the fact that the new column widths were computed only after rendering, such that some columns were lacking a width.

Sizes of columns that have been manually resized are kept, even if the query changes.

Closes #1073.


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
    • Honestly, I have no idea whether this is the case. I barely managed to get a setup working at all, which took >1.5h. Would need additional instructions to check this (if it isn't done automatically in a pipeline). Since the changes are small and I didn't see anything in the IDE, I would assume that it is the case. EDIT: I ran the pipeline in my own fork and it's looking good.
  • You have made the needed changes to the docs
    • Since this is a bugfix, no changes are required
  • You have written a description of what is the purpose of this pull request above

@gjsjohnmurray gjsjohnmurray self-requested a review January 4, 2023 11:14
Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this.

@gjsjohnmurray gjsjohnmurray merged commit a43b5a1 into mtxr:dev Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reused tab shows error when columns change
2 participants