Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add 'none' option to location to skip showing query result #1161

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

bombillazo
Copy link
Contributor

Resolves #1158

This request is to prevent a query result window from opening. This is useful when running setup or idempotent update scripts, and one has a fixed dev layout that is inevitably altered when running a script from the IDE.


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

@bombillazo
Copy link
Contributor Author

Hey @gjsjohnmurray @george-james-software @mtxr, I am submitting this PR for your consideration and review to resolve the related issue #1158 . Thanks!

@bombillazo
Copy link
Contributor Author

Any thoughts on this? Does it look ok to merge?

@gjsjohnmurray
Copy link
Collaborator

Please update your branch from dev to fix the CI failure (#1167 is related)

@bombillazo
Copy link
Contributor Author

@gjsjohnmurray Done.

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@gjsjohnmurray gjsjohnmurray merged commit 2fe5ea5 into mtxr:dev Jun 22, 2023
4 checks passed
@bombillazo
Copy link
Contributor Author

Quick question, how often is the published release updated?

@gjsjohnmurray
Copy link
Collaborator

Quick question, how often is the published release updated?

I'm working on one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None result location
2 participants