Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve connection quickpick and status bar item #1258

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

gjsjohnmurray
Copy link
Collaborator

  • Clarify ownership of our status bar item.
  • Deprecate sqltools.showStatusbar setting in favour of VS Code's built-in controls of panel item visibility.
  • Use + codicon for connection picker toolbar button because our dark-mode SVG was invisible in some color themes.
  • Also show + button on connection quickpick when no connections exist.

@gjsjohnmurray
Copy link
Collaborator Author

@george-james-software please review this when you have a chance.

@gjsjohnmurray gjsjohnmurray merged commit 3bb336d into mtxr:dev Jan 2, 2024
2 checks passed
@gjsjohnmurray gjsjohnmurray deleted the jade-rattlesnake branch January 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants