Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][#72][#799][#1264]Not able to connect to AWS RDS postgresql #1265

Merged
merged 3 commits into from Dec 29, 2023
Merged

[Fix][#72][#799][#1264]Not able to connect to AWS RDS postgresql #1265

merged 3 commits into from Dec 29, 2023

Conversation

jqknono
Copy link
Contributor

@jqknono jqknono commented Dec 29, 2023

Fix not able to connect to AWS RDS Postgresql


  • Changed the default setting schema.
  • Tested on Windows & Linux.

@gjsjohnmurray
Copy link
Collaborator

Is this changing the default behaviour of the driver, making it less secure?

My understanding of https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener is that we should only pass "rejectUnauthorized": false if the user explicitly opts for this.

Isn't it sufficient to add "default": true to the definition of rejectUnauthorized in connection.schema.json?

@gjsjohnmurray
Copy link
Collaborator

Thanks for making the changes. I noticed you have left the property required. Is this necessary?

@jqknono
Copy link
Contributor Author

jqknono commented Dec 29, 2023

Is this changing the default behaviour of the driver, making it less secure?

My understanding of https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener is that we should only pass "rejectUnauthorized": false if the user explicitly opts for this.

Isn't it sufficient to add "default": true to the definition of rejectUnauthorized in connection.schema.json?

Yes, you're right. I revert the changing of rejectUnauthorized, it's now default "true".
Tested both Windows/Linux.
image

@jqknono
Copy link
Contributor Author

jqknono commented Dec 29, 2023

Thanks for making the changes. I noticed you have left the property required. Is this necessary?

required is not necessary, I just removed it.

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@gjsjohnmurray gjsjohnmurray merged commit b0dd32a into mtxr:dev Dec 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants