Add Cassandra driver #379
Merged
Add Cassandra driver #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently there are some issues with the code, I'll close the PR for now and reopen after they're done. |
|
Hi @EpicEric. I'll update the tutorial and fix the conflicts of this PR. Thank you very much. Great job! |
|
I've improved the general logic, removed code re-usage and added Docker tests. This is now ready for review. |
mtxr
approved these changes
Sep 16, 2019
|
AWESOME! I didn't even documented the new UI changes nor updated the tutorial but you followed all the required patterns. Thanks @EpicEric Merging... |
|
@EpicEric Can I assign futures issues for Cassandra to you? I'm looking for maintainers for each driver. That would help me a lot |
|
No problem. You can assign them to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to Cassandra and any other databases that use CQL into SQLTools, and adds documentation on the setup.
This has been tested with both Cassandra and Scylla instances.