Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cassandra driver #379

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@EpicEric
Copy link
Contributor

commented Sep 12, 2019

This PR adds support to Cassandra and any other databases that use CQL into SQLTools, and adds documentation on the setup.

This has been tested with both Cassandra and Scylla instances.

@EpicEric

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Apparently there are some issues with the code, I'll close the PR for now and reopen after they're done.

@EpicEric EpicEric closed this Sep 12, 2019
@mtxr

This comment has been minimized.

Copy link
Owner

commented Sep 12, 2019

Hi @EpicEric.

I'll update the tutorial and fix the conflicts of this PR.
I'm doing some engineering changes, so let's work on this together. I'll do this after work today

Thank you very much.

Great job!

@mtxr mtxr reopened this Sep 12, 2019
@mtxr mtxr self-requested a review Sep 12, 2019
@mtxr mtxr changed the title Add Cassandra driver WIP: Add Cassandra driver Sep 12, 2019
@EpicEric EpicEric force-pushed the EpicEric:cassandra branch from f2218e3 to 549d044 Sep 12, 2019
@EpicEric EpicEric force-pushed the EpicEric:cassandra branch from 549d044 to 156b2b4 Sep 12, 2019
@EpicEric

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

I've improved the general logic, removed code re-usage and added Docker tests. This is now ready for review.

@mtxr
mtxr approved these changes Sep 16, 2019
@mtxr

This comment has been minimized.

Copy link
Owner

commented Sep 16, 2019

AWESOME! I didn't even documented the new UI changes nor updated the tutorial but you followed all the required patterns. Thanks @EpicEric

Merging...

@mtxr mtxr merged commit 2090ef2 into mtxr:master Sep 16, 2019
1 of 3 checks passed
1 of 3 checks passed
Mergeable Mergeable run returned Status ***FAIL***
Details
Travis CI - Pull Request Build Failed
Details
codeclimate All good!
Details
@mtxr

This comment has been minimized.

Copy link
Owner

commented Sep 16, 2019

@EpicEric Can I assign futures issues for Cassandra to you?

I'm looking for maintainers for each driver. That would help me a lot

@EpicEric

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

No problem. You can assign them to me.

@EpicEric EpicEric deleted the EpicEric:cassandra branch Sep 16, 2019
@mtxr mtxr changed the title WIP: Add Cassandra driver Add Cassandra driver Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.