Improve Cassandra visualization #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Here's a comparison of the visual changes (left = before, right = after):
|
- Add isPartitionKey field for columns, with new icon for partition keys - Add Cassandra-specific hierarchy child name - Get number of columns per table in Cassandra - Fix column size when `size` field is undefined
mtxr
reviewed
Oct 23, 2019
| @@ -140,6 +140,7 @@ export namespace DatabaseInterface { | |||
| tableCatalog?: string; | |||
| defaultValue?: string; | |||
| isNullable: boolean; | |||
| isPartitionKey?: boolean; | |||
There was a problem hiding this comment.
Thankfully you choose a better naming for those keys 🎊
I'll rename isPk and isFk to make it more readable.
mtxr
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizefield is undefinedThank you for your contribution!
Before submitting this PR, please make sure: