Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing queries to be compatible with MSSQL2000 #440

Merged
merged 2 commits into from Nov 6, 2019
Merged

Conversation

glha
Copy link
Contributor

@glha glha commented Nov 5, 2019

Changing the queries to be compatible with MSSQL Server 2000 (v8.x), replacing CONCAT with ISNULL(string, '') + next string and STRING_AGG with a COALESCE(STUFF(ISNULL())) mix.

Closes #418

Changing the queries to be compatible with MSSQL Server 2000 (v8.x), replacing CONCAT with ISNULL(string, '') + next string and STRING_AGG with a COALESCE(STUFF(ISNULL())) mix.
@mtxr mtxr self-requested a review November 5, 2019 21:09
@mtxr mtxr assigned glha Nov 5, 2019
@mtxr mtxr added enhancement mssql Microsoft SQL Server driver labels Nov 5, 2019
@mtxr mtxr added this to the v0.21 milestone Nov 5, 2019
@mtxr
Copy link
Owner

mtxr commented Nov 6, 2019

Works like a charm!

@mtxr mtxr merged commit d661de9 into mtxr:master Nov 6, 2019
glha added a commit to glha/vscode-sqltools that referenced this pull request Nov 6, 2019
Forgot to clean comma from removed column and the very CONCAT used as an example in mtxr#440, was not converted using the ISNULL() approach.
glha added a commit to glha/vscode-sqltools that referenced this pull request Nov 6, 2019
Forgot to clean comma from removed column and the very CONCAT used as an example in mtxr#440, was not converted using the ISNULL() approach.
mtxr pushed a commit that referenced this pull request Nov 6, 2019
* Changing queries to be compatible with MSSQL2000

Changing the queries to be compatible with MSSQL Server 2000 (v8.x), replacing CONCAT with ISNULL(string, '') + next string and STRING_AGG with a COALESCE(STUFF(ISNULL())) mix.

* Cleanup from removed column and overlooked CONCAT

Forgot to clean comma from removed column and the very CONCAT used as an example in #440, was not converted using the ISNULL() approach.

* Revert "Cleanup from removed column and overlooked CONCAT"

This reverts commit eec1e55.

* Cleanup from removed column and overlooked CONCAT

Forgot to clean comma from removed column and the very CONCAT used as an example in #440, was not converted using the ISNULL() approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement mssql Microsoft SQL Server driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't connect to MSSQL Server 8.x
2 participants