Fix disappearing connections after browser refresh in Theia #530

[ShimonBenYair]

Signed-off-by: Shimon Ben.Yair shimon.ben.yair@sap.com

This PR fixes the problem that after adding a new connection (for example sqlite/hana) it is being saved in the settings.json and is displayed ok, but after refresh it disappears.

Close #530

---

Thank you for your contribution!
Before submitting this PR, please make sure:

• Your code builds clean without any errors or warnings
• You have made the needed changes to the docs
• You have wrote a description of what is the purpose of this pull request above

[ShimonBenYair]

@mtxr
Can you please code review and merge this pull request ?

[mtxr]

@ShimonBenYair I'll do this tonight. In a hurry here

[mtxr]

@ShimonBenYair your PR looks fine, although I'ld rather prefer if we could call explorer.updateTreeRoot() in the last line of https://github.com/ShimonBenYair/vscode-sqltools/blob/missingconnections/packages/plugins/connection-manager/extension.ts#L632 instead of making explorer public. This changed in another branch, so if you can move this call to the register method, it should have the same effect and will make easier for me to resolve conflicts in the other branch

How does it sound?

[mtxr]

Please check aforementioned comments

[ShimonBenYair]

@mtxr

done, please merge

[ShimonBenYair]

@mtxr
Do you know when 0.21.8 version will be released ?

[mtxr]

Today EOD

…

On Wed, May 6, 2020 at 9:10 AM ShimonBenYair ***@***.***> wrote: @mtxr <https://github.com/mtxr> Do you know when 0.21.8 version will be released ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#554 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFMX2LJH25VO2WCNEKQAPTRQFHR7ANCNFSM4MYTR6YA> .

[ShimonBenYair]

Today EOD
…
On Wed, May 6, 2020 at 9:10 AM ShimonBenYair @.***> wrote: @mtxr https://github.com/mtxr Do you know when 0.21.8 version will be released ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#554 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMX2LJH25VO2WCNEKQAPTRQFHR7ANCNFSM4MYTR6YA .

The new version was not released right ?
in the tags i still see 0.21.6
and in the vscode marketplace it is 0.21.7