Fix some flakiness caused by PR #957 #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.registerBaseNotifications() was being called before this.client had been instantiated
When this happened a PowerShell node-detection shell would fail to close. Probably a timing issue, as adding a retry loop seems to fix it.
|
Upstream issue microsoft/vscode#160694 |
mtxr
reviewed
Sep 14, 2022
mtxr
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows at least, the node path auto-detect changes from #957 were producing intermittent failures. One of these was caused by vscode.env.shell sometimes being empty, perhaps a consequence of being called very early in VS Code startup.