Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests with Python 3.8 fails #2500

Closed
carlosperate opened this issue Jan 31, 2024 · 1 comment · Fixed by #2502
Closed

Running tests with Python 3.8 fails #2500

carlosperate opened this issue Jan 31, 2024 · 1 comment · Fixed by #2502
Labels
Milestone

Comments

@carlosperate
Copy link
Member

carlosperate commented Jan 31, 2024

All CI jobs with Python 3.8+ are now failing, without any changes in this codebase to trigger this.

As an example, the latest commit in main is: 5e4067b

When it was pushed, all tests passed: https://github.com/mu-editor/mu/actions/runs/7504275586/attempts/1
I've restarted the jobs and Python 3.8 fails: https://github.com/mu-editor/mu/actions/runs/7504275586

This job for PR #2487, which uses Python 3.7 to 3.11, and only 3.7 passes:

As the commit was pushed on the 12th of January, something in the runners or the Pyhon action must have changed since then (edit: can replicate locally with a clean installation of Mu in a Python 3.8 virtual env):

@carlosperate carlosperate changed the title CI: All test jobs are failing except for Python 3.7 CI: All test jobs are with Python 3.8+ are failing Jan 31, 2024
@carlosperate carlosperate changed the title CI: All test jobs are with Python 3.8+ are failing CI: All test jobs with Python 3.8+ are failing Jan 31, 2024
@carlosperate
Copy link
Member Author

Looks like the issue is with a change introduced in pytest v8.0.0 (Python 3.8+), as setting the max pytest version to v7.4.4 works.

@carlosperate carlosperate added this to the 1.2.1 milestone Feb 4, 2024
@carlosperate carlosperate changed the title CI: All test jobs with Python 3.8+ are failing Running tests with Python 3.8 fails Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant