Ensure, if no file extension provided, a .py one is used. #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -420,6 +420,12 @@ def get_save_path(self, folder): | |||
| "Python (*.py)", | |||
| ) | |||
| self.previous_folder = os.path.dirname(path) | |||
| # Ensure there's a .py extension if none is provided by the user. | |||
| # See issue #1571. | |||
| name, ext = os.path.splitext(os.path.basename(path)) | |||
There was a problem hiding this comment.
Just a warning that this does not work with dot files, so something like .gitignore will be renamed to .gitignore.py. We can probably consider this out of scope, but I thought it was worth pointing out.
There was a problem hiding this comment.
Good point. For safety we should probably wrap the code in a conditional like if not name.startswith("."):
There was a problem hiding this comment.
OK... fixed and tested in latest commit on this branch. Will merge once the CI turns green. 👍 Thanks for the heads-up @carlosperate
ntoll
force-pushed
the
ensure-py-file-ext
branch
from
7f5a90b
to
4db1b06
Compare
This was referenced Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571.