designer.appendTo now supports load-callback

designer.appendTo(documetn.body, function() { alert('loaded into documetn.body'); });
muaz-khan · Oct 25, 2018 · 26ffa66 · 26ffa66
1 parent 197233d
commit 26ffa66
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 20 deletions.
diff --git a/.npmignore b/.npmignore
@@ -1,18 +1,14 @@
-node_modules
-bower_components
+# ignore everything
+*
 
-*.tar.gz
-lib-cov
-
-.*.swp
-._*
-.DS_Store
-.git
-.hg
-.npmrc
-.lock-wscript
-.svn
-.wafpickle-*
-config.gypi
-CVS
-npm-debug.log
+# but not these files...
+!canvas-designer-widget.js
+!widget.html
+!widget.js
+!widget.min.js
+!dev/webrtc-handler.js
+!index.html
+!package.json
+!bower.json
+!server.js
+!README.md
diff --git a/README.md b/README.md
@@ -331,6 +331,11 @@ CanvasDesigner is a widget; that widget should be appended to a DOM object. This
 
 ```javascript
 designer.appendTo(document.body || document.documentElement);
+
+// or
+designer.appendTo(document.body || document.documentElement, function() {
+    alert('iframe load callback');
+});
 ```
 
 The correct name for `appendTo` is: `append-iframe to target HTML-DOM-element`

diff --git a/bower.json b/bower.json
@@ -1,7 +1,7 @@
 {
   "name": "canvas-designer",
   "preferGlobal": false,
-  "version": "1.2.4",
+  "version": "1.2.5",
   "author": {
     "name": "Muaz Khan",
     "email": "muazkh@gmail.com",

diff --git a/canvas-designer-widget.js b/canvas-designer-widget.js
@@ -50,6 +50,7 @@ function CanvasDesigner() {
         pdf: null,
         pdf_next: null,
         pdf_prev: null,
+        pdf_close: null,
         marker: null,
         zoom: null,
         lineWidth: null,
@@ -114,8 +115,17 @@ function CanvasDesigner() {
 
     designer.uid = getRandomString();
 
-    designer.appendTo = function(parentNode) {
+    designer.appendTo = function(parentNode, callback) {
+        callback = callback || function() {};
+
         designer.iframe = document.createElement('iframe');
+
+        // designer load callback
+        designer.iframe.onload = function() {
+            callback();
+            callback = null;
+        };
+
         designer.iframe.src = designer.widgetHtmlURL + '?widgetJsURL=' + designer.widgetJsURL + '&tools=' + JSON.stringify(tools) + '&selectedIcon=' + selectedIcon + '&icons=' + JSON.stringify(designer.icons);
         designer.iframe.style.width = '100%';
         designer.iframe.style.height = '100%';

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "canvas-designer",
   "preferGlobal": false,
-  "version": "1.2.4",
+  "version": "1.2.5",
   "author": {
     "name": "Muaz Khan",
     "email": "muazkh@gmail.com",