Fixed some errors that can occur when using Edge browser, when RTCPeerConnection is not implemented (ie. Edge), and when candidates have IPv6 addresses (Chrome and others too?) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is can occur if the candidate has an IPv6 address for example)
|
Just a little more background on the IPV6 thing... I don't know why some of my candidates are coming in with IPV6 addresses, but I don't think I need or want them, so it is ok... I'm just trying to make it avoid having an error if that occurs. May want to consider adding IPV6 support in the backlog though. |
muaz-khan
added a commit
that referenced
this pull request
Nov 30, 2015
Fixed some errors that can occur when using Edge browser, when RTCPeerConnection is not implemented (ie. Edge), and when candidates have IPv6 addresses (Chrome and others too?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't worry about trying to change the regex to match IPv6 addresses, I just left the matching code as-is and made it so that it does not cause an error message if it gets candidates with IPv6 addresses.