You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, there's a bug, line number 2646
if (!defaultSocket) {
return setTimeout(function () {
connection.sendMessage(message);
}, 1000);
}
There's no such function as connection.sendMessage, there's only connection.sendCustomMessage(), please fix.
By the way haven't you think about using TDD and feature branching or at least writing unit tests for your library? Otherwise there'll bee constant code regression.
Also, instead of having one big repository and putting the libraries in its subfolders and keeping each older version for each library you could use Git capabilities:
it's possible to create a separate repository for each library and add them into the main repository as Git submodules, see the documentation: http://git-scm.com/book/en/Git-Tools-Submodules - this way it will be much easier to track the issues and maintain the code and the versions and for users there will be no difference, they would be able to click on a specific submodule and go to its repo.
it's better to mark stable releases (like RTCMultiConnection-v1.7) with Git tags instead of keeping all the versions as separate files, see the documentation here: http://git-scm.com/book/en/Git-Basics-Tagging
If there's a need to make a minor change to a major version just add a minor postfix to the version number in the tag name, like 1.8.1, 1.8.1.1, in this case the users will be sure that they use the right version that was working before and new updates will not break their application.
The text was updated successfully, but these errors were encountered:
Hey, there's a bug, line number 2646
if (!defaultSocket) {
return setTimeout(function () {
connection.sendMessage(message);
}, 1000);
}
There's no such function as connection.sendMessage, there's only connection.sendCustomMessage(), please fix.
By the way haven't you think about using TDD and feature branching or at least writing unit tests for your library? Otherwise there'll bee constant code regression.
Also, instead of having one big repository and putting the libraries in its subfolders and keeping each older version for each library you could use Git capabilities:
If there's a need to make a minor change to a major version just add a minor postfix to the version number in the tag name, like 1.8.1, 1.8.1.1, in this case the users will be sure that they use the right version that was working before and new updates will not break their application.
The text was updated successfully, but these errors were encountered: