Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set property 'submenu' #338

Closed
fridzema opened this issue Jul 10, 2019 · 2 comments
Closed

Cannot set property 'submenu' #338

fridzema opened this issue Jul 10, 2019 · 2 comments

Comments

@fridzema
Copy link

Hello,

After a fresh install and running npm run debug i get the following error:
Screenshot 2019-07-10 at 14 37 47

Anyone else experiencing this?

@mubaidr
Copy link
Owner

mubaidr commented Jul 10, 2019

The issue is here: https://github.com/mubaidr/vue-electron-template/blob/master/src/main/index.js#L193

please remove following content from the above file:

// Edit menu
    template[1].submenu.push(
      // @ts-ignore
      { type: 'separator' },
      {
        label: 'Speech',
        submenu: [{ role: 'startspeaking' }, { role: 'stopspeaking' }],
      }
    )

    // Window menu
    template[3].submenu = [
      { role: 'close' },
      { role: 'minimize' },
      { role: 'zoom' },
      { type: 'separator' },
      { role: 'front' },
    ]

I missed it because I don't have macos. I will update the template.

@mubaidr
Copy link
Owner

mubaidr commented Jul 10, 2019

Should be fixed in: c00f0ad

@mubaidr mubaidr closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants