Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules #17

Open
raulvillares opened this issue May 25, 2017 · 11 comments
Open

Modules #17

raulvillares opened this issue May 25, 2017 · 11 comments

Comments

@raulvillares
Copy link
Contributor

Because the project is growing, interdependencies between different parts are becoming difficult to understand and to change.

Modulalization will help. Options seem to be:

  • Module pattern
  • CommonJS modules
  • AMD (Asynchronous Module Definition)

http://eloquentjavascript.net/10_modules.html

@mubaris
Copy link
Owner

mubaris commented May 25, 2017

Seems like a good suggestion.

@alejandronanez
Copy link
Contributor

I think UMD and ES modules are the way to go here. :)
Ping me if you need something @mubaris

@mubaris
Copy link
Owner

mubaris commented Jun 1, 2017

@alejandronanez I was reading about Webpack for this issue. Is it okay to go with Webpack?

@alejandronanez
Copy link
Contributor

Webpack is a good choice IMO.
Webpack is better for apps and Rollup for libraries.

@mubaris mubaris added the V2 label Jun 1, 2017
@mubaris mubaris added this to In Progress in V2 Jun 1, 2017
@alejandronanez
Copy link
Contributor

@mubaris let me know if you need any help setting up webpack.

This was referenced Jun 5, 2017
@alejandronanez
Copy link
Contributor

alejandronanez commented Jun 5, 2017

Actually @mubaris if we decide to go with React #35 ...we should ended up rewriting the whole thing...and if that's the case, we can just use create-react-app

Thoughts @raulvillares @mubaris @junedomingo @asiyani @maiquynhtruong ?

@raulvillares
Copy link
Contributor Author

raulvillares commented Jun 5, 2017

I don't know much about Webpack, but I've just modularized a small vanilla js puzzle-game with Require.js and I'm happy with that. If vanilla js is still an option for issue #35 maybe we can consider Require?

@alejandronanez
Copy link
Contributor

@raulvillares
Just to mention that for the learning experience I find way more valuable to have Webpack in our stack rather than RequireJS.
Plus, RequireJS is just a way to manage our dependencies, it doesn't give us all the niceties that webpack offers: ES Modules / ES6 / Treat everything as a module (images, fonts, css) / tree shaking, etc...

@raulvillares
Copy link
Contributor Author

Yeah, I guessed Webpack was wider than Require.

@mubaris mubaris self-assigned this Jun 6, 2017
@maiquynhtruong
Copy link
Contributor

Are we still using webpack or React? Have we decided on something to use yet?
Include @asiyani in here

@alejandronanez
Copy link
Contributor

Nothing has been defined yet, we have that conversation split between different threads sighs take a look at #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
V2
In Progress
Development

No branches or pull requests

4 participants