Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38 Add all contributes #46

Merged
merged 11 commits into from
Jun 7, 2017
Merged

Conversation

vvvdeep
Copy link

@vvvdeep vvvdeep commented Jun 6, 2017

Closes #38
Added all contributors section per #38 .
I have added initial contributors I found under https://github.com/curiositylab/curiosity/graphs/contributors-data. Let me know if we need to add more. ( There is an ongoing discussion about automating some of this over all-contributors/all-contributors#18 )

I can write a small description on how to add to the contributors list or we can point to https://www.npmjs.com/package/all-contributors-cli or https://github.com/kentcdodds/all-contributors. Personally, I think a small description here would be quicker for new users.

Also, I have disabled auto commit on new contributor addition/updation as that might not be something everyone would want when playing around.

P.S.- I was not sure about type of contributions for each one so that data in the branch is my guesswork from your commits. Bots not included.

Attached a snapshot:-
all contributors

package.json Outdated
"codecov": "^2.2.0",
"eslint": "^3.19.0",
"eslint-config-airbnb-base": "^11.2.0",
"eslint-plugin-import": "^2.3.0",
"mocha": "^3.4.2"
},
"scripts": {
"lint": "eslint js/**/*.js"
"lint": "eslint js/**/*.js",
"add": "all-contributors add",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this more clear, can you make the command something like all-contributors:add and all-contributors:generate?

@@ -6,14 +6,17 @@
"author": "Mubaris",
"license": "MIT",
"devDependencies": {
"all-contributors-cli": "^4.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using YARN in here, can you please add this dependency by doing yarn add all-contributors-cli -D instead of the old plain npm install ....

@alejandronanez
Copy link
Contributor

alejandronanez commented Jun 6, 2017

Hey @vvvdeep first of all welcome!!! thanks for taking time to work on this!

I left a couple of minor changes there.

Also, I think @asiyani @mubaris @raulvillares @maiquynhtruong and I have participated by reviewing pull requests too, you can add that also.

@mubaris if you think something else needs to be included for someone in particular under all contributors, just ping @vvvdeep

@vvvdeep
Copy link
Author

vvvdeep commented Jun 6, 2017

thanks @alejandronanez . Just updated the PR with your review comments.

@mubaris mubaris self-requested a review June 7, 2017 05:59
Copy link
Owner

@mubaris mubaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good work @vvvdeep 👍 Thanks

@mubaris mubaris dismissed alejandronanez’s stale review June 7, 2017 06:01

vvvdeep has already modified the requests

@mubaris mubaris merged commit 3ebdac3 into mubaris:master Jun 7, 2017
@alejandronanez
Copy link
Contributor

Thanks @vvvdeep ! this is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants