Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change timeout of filter invalidation #775

Closed
tomasMizera opened this issue Oct 18, 2022 · 3 comments · Fixed by #786
Closed

Add ability to change timeout of filter invalidation #775

tomasMizera opened this issue Oct 18, 2022 · 3 comments · Fixed by #786
Milestone

Comments

@tomasMizera
Copy link

Hi all,

I am having a hard time using the filtering feature (typing letters in a directory to jump over files that match the string, see video).

The default timeout to invalidate the search is too quick for me. When I search for a file without knowing the exact name, the search invalidates while reading the file name and I need to type it in again (it even jumps to the first entry again!) 🙃

I was wondering if we could have an option in settings to make the search permanent (do not invalidate after a few seconds) or have some variable to manipulate the timeout. Thanks for the good work!

20221018144714560.mp4
@ahadas
Copy link
Member

ahadas commented Oct 20, 2022

@tomasMizera thanks for reporting this, yeah, it's hard coded to 2 seconds. I think it's a good idea to make it configurable as you suggest (it was also implemented in trolcommander)

@ahadas ahadas added this to the 1.2.0 milestone Oct 20, 2022
ahadas added a commit to ahadas/mucommander that referenced this issue Oct 29, 2022
ahadas added a commit to ahadas/mucommander that referenced this issue Oct 29, 2022
@ahadas ahadas closed this as completed in 32b0a3f Oct 29, 2022
@ahadas ahadas linked a pull request Oct 29, 2022 that will close this issue
@ahadas
Copy link
Member

ahadas commented Mar 12, 2023

Version 1.2.0 that includes a fix for this issue has been released

@tomasMizera
Copy link
Author

Marvellous!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants