Native icons for drive button #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
reviewed
May 16, 2022
There was a problem hiding this comment.
@pskowronek thanks for posting this. yeah, I see why it was not easy to pick a good name and representation to this setting - commented inline with a suggestion for an alternative way
mucommander-preferences/src/main/java/com/mucommander/conf/SystemIconsPolicy.java
Outdated
Show resolved
Hide resolved
pskowronek
force-pushed
the
native-icons-drive-button
branch
from
4860da8
to
10fa346
Compare
|
Rebased and modified the preference option (For folders only) and updated logic behind accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
To consider: