Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser #103

Merged
merged 3 commits into from Feb 21, 2024
Merged

Parser #103

merged 3 commits into from Feb 21, 2024

Conversation

pwfreedm
Copy link
Contributor

@pwfreedm pwfreedm commented Feb 21, 2024

  • Lexer: reads a command from CLI input, splits it into parseable chunks (a string that is a command and a series of string flags)
  • Parser: reads the parseable chunks from a lexer, turning them into a command and arguments (turns the string command into an instance of a command object that is being applied to the correct instance (if needed) with a list of args to pass to that command appended to it)
  • method check_args is floating so that it can be used wherever needed (namely controller save and load)

This passed all tests before uploading

- Moved parser and lexer into their own files
- updated gitignore for arch venv directories
- Lexer: reads a command from user input, splits it into parseable chunks
- Parser: reads the parseable chunks from the lexer, turning them into a command and arguments
- method check_args is floating so that it can be used wherever needed (namely controller save and load)

This passed all tests before uploading
These tests no longer create a controller, and as such can no longer test controller methods. This will be fixed when everything is rewritten in pytest
@timbmoser timbmoser merged commit 0767f4a into develop Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants