Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api docs #36

Merged
merged 13 commits into from
Oct 28, 2018
Merged

Api docs #36

merged 13 commits into from
Oct 28, 2018

Conversation

mucsi96
Copy link
Owner

@mucsi96 mucsi96 commented Oct 28, 2018

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 72.561%

Files with Coverage Reduction New Missed Lines %
src/index.ts 3 55.56%
src/client.ts 9 65.33%
Totals Coverage Status
Change from base Build 167: 0.8%
Covered Lines: 85
Relevant Lines: 107

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 28, 2018

Pull Request Test Coverage Report for Build 180

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 72.561%

Files with Coverage Reduction New Missed Lines %
src/index.ts 3 55.56%
src/client.ts 9 65.33%
Totals Coverage Status
Change from base Build 167: 0.8%
Covered Lines: 85
Relevant Lines: 107

💛 - Coveralls

export { stopWebDriver, closeSession } from './client';
/**
* This variable represents the Nightwatch webdriver client.
* This is the main part fo this package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo ;) "part of"

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! 🤣 Thank you so much! Adding you to contributors list. Can you check the whole docs site after this has been merged?

Copy link
Collaborator

@spnraju spnraju Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be my pleasure. 👍

@mucsi96 mucsi96 merged commit 361985b into master Oct 28, 2018
@mucsi96 mucsi96 deleted the api-docs branch October 28, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants