Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on the Section object #343

Merged
merged 2 commits into from Feb 7, 2018

Conversation

clayreimann
Copy link

No description provided.

@clayreimann
Copy link
Author

clayreimann commented Feb 2, 2018

@mucsi96 some documentation for the Section object added in #340

@clayreimann
Copy link
Author

@mucsi96 bump cuz it's Monday 😄

@mucsi96
Copy link
Owner

mucsi96 commented Feb 5, 2018

😀👍🙏

@clayreimann
Copy link
Author

clayreimann commented Feb 6, 2018

@mucsi96, perhaps this and #340 can merge? The only check failing here is codacy (because it can't read the PR)

@mucsi96
Copy link
Owner

mucsi96 commented Feb 6, 2018

Yes. Will do it this week. Sorry for taking it so long :(

Copy link
Owner

@mucsi96 mucsi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@mucsi96 mucsi96 merged commit fa643db into mucsi96:promisify-section Feb 7, 2018
mucsi96 pushed a commit that referenced this pull request Feb 7, 2018
* Update packages

* compiler -> require-module

* Downgrade jsdom to 11.5.1

* Fix require-module config

* Fix execution result handling

* Update peer dependencies

* Add Section cinstructor to API

* Fix code-style issues

* Add missing run to page object test

* Add documentation on the Section object (#343)

* Add documentation on the Section object

* Fix section test

* Add @amurdock as a contributor

* Add @clayreimann as a contributor

* Fix contributors

* Fix eslint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants