Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript Capstone Kanban Set Up #21

Open
mudasiri opened this issue Nov 29, 2022 · 6 comments
Open

Javascript Capstone Kanban Set Up #21

mudasiri opened this issue Nov 29, 2022 · 6 comments

Comments

@mudasiri
Copy link
Owner

mudasiri commented Nov 29, 2022

Dear reviewer,
We are a team of two partners and we have just completed setting up our kanban project. Kindly review it for us so we can kick start. Thanks in advance.

Kanban Link: Kanban Link
Project Link: GitHub code Link

@Davidosky007
Copy link

Hi @mudasiri 👋,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that doesn't contain the right link to your Kanban board project ( the link to the board itself) below 👇 is an example
image

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@Gopxfs
Copy link

Gopxfs commented Nov 29, 2022

Hello team 👋, the link to the kanban board is broken:

image

@Gopxfs
Copy link

Gopxfs commented Nov 29, 2022

STATUS: INVALID REQUEST

Hi team👋,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project that doesn't contain a link to the kanban board

Your Code Review Request will be marked invalid in your Dashboard, so please submit a new one once ready 🙏.
Invalid requests don't count as a review, so don't worry about that 😄!

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Gopxfs in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@Ismailco
Copy link

Hi @mudasiri,

Good job so far 👍🏼
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ Used Kanban board
✔️ Board has all the tasks

Required Changes ♻️

  • all cards should be assigned to team members, kindly consider assigning every card to a team member, and keep in mind to distribute the tasks in a fair way
    Screenshot_20221129_183111
    Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@aimalamiri
Copy link

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to begin working on the next task :shipit:
Congratulations! 🎉

ApprovedDavieGIF

Highlights

  • The Kanban board setup is completed 🟢 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mudasiri
Copy link
Owner Author

Thanks for the review and approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants