fix unsymmetric spacing

mudassir0909 · Mar 21, 2016 · 7841e77 · 7841e77
1 parent 71953a4
commit 7841e77
Show file tree

Hide file tree

Showing 14 changed files with 43 additions and 26 deletions.
diff --git a/assets/css/theme.css b/assets/css/theme.css
@@ -183,6 +183,9 @@
 .space-right {
   margin-right: 10px;
 }
+.space-bottom {
+  margin-bottom: 10px;
+}
 .mr-5 {
   margin-right: 5px;
 }
@@ -257,11 +260,10 @@ body {
   border: 1px solid #e6e6e6;
   border-radius: 3px;
   min-height: 300px;
-  padding: 10px;
+  padding: 10px 0;
 }
 .card-nested {
   min-height: 0;
-  margin-bottom: 10px;
   border-width: 1px 0 0 0;
 }
 .card-nested:before,
@@ -290,7 +292,6 @@ body {
 }
 .background-details .detail {
   display: table;
-  padding: 10px 0;
 }
 .background-details .detail .icon {
   min-width: 45px;
@@ -375,6 +376,9 @@ body {
   top: 4px;
   left: -10px;
 }
+.mop-wrapper > p:last-child {
+  margin: 0;
+}
 /*
     Credits: http://codyhouse.co/demo/smart-fixed-navigation/index.html
 */
@@ -481,6 +485,9 @@ body {
     position: relative;
   }
 }
+.profile-card-wrapper .profile-card {
+  padding: 10px;
+}
 .profile-pic {
   padding: 20px 0;
 }
@@ -818,9 +825,6 @@ body {
   height: 95%;
   background: #5cb85c;
 }
-.skill-info {
-  margin-left: 10px;
-}
 @media (max-width: 480px) {
   .skill-info {
     margin-left: 20px;

diff --git a/assets/less/base.less b/assets/less/base.less
@@ -16,13 +16,12 @@ body {
     border: 1px solid @card-border-color;
     border-radius: @card-border-radius;
     min-height: 300px;
-    padding: 10px;
+    padding: 10px 0;
 }
 
 .card-nested {
     .clearfix();
     min-height: 0;
-    margin-bottom: 10px;
     border-width: 1px 0 0 0;
 
     @media (max-width: @screen-phone) {
@@ -45,7 +44,6 @@ body {
 .background-details {
     .detail {
         display: table;
-        padding: 10px 0;
 
         .icon {
             min-width: 45px;
@@ -136,3 +134,11 @@ ul {
     top: 4px;
     left: -10px;
 }
+
+.mop-wrapper { //mardown output wrapper
+    > p { // markdown outputs the result wrapped in a <p> tag, bootstrap has default margin for this tag, so negating it
+        &:last-child {
+            margin: 0;
+        }
+    }
+}
diff --git a/assets/less/info_card_styles.less b/assets/less/info_card_styles.less
@@ -2,6 +2,10 @@
     @media (max-width: @screen-desktop) {
         position: relative;
     }
+
+    .profile-card {
+        padding: 10px;
+    }
 }
 
 .profile-pic {

diff --git a/assets/less/sections/skills.less b/assets/less/sections/skills.less
@@ -44,8 +44,6 @@
 }
 
 .skill-info {
-    margin-left: 10px;
-
     @media (max-width: @screen-phone) {
         margin-left: 20px;
     }

diff --git a/assets/less/utilities.less b/assets/less/utilities.less
@@ -14,6 +14,10 @@
     margin-right: 10px;
 }
 
+.space-bottom {
+    margin-bottom: 10px;
+}
+
 .mr-5 {
     margin-right: 5px;
 }

diff --git a/jade/background/about.jade b/jade/background/about.jade
@@ -6,4 +6,5 @@ unless _.isEmpty(resume.basics.summary)
     .info
       h4.title.text-uppercase About
 
-      .content(itemprop="description")!= resume.basics.summary
+      .card.card-nested
+        .content.mop-wrapper(itemprop="description")!= resume.basics.summary
diff --git a/jade/background/awards.jade b/jade/background/awards.jade
@@ -8,7 +8,7 @@ unless _.isEmpty(resume.awards)
       h4.title.text-uppercase Awards
 
       .content
-        ul.list-unstyled
+        ul.list-unstyled.clear-margin
           - each award in resume.awards
             li.card.card-nested
               .content
@@ -20,4 +20,4 @@ unless _.isEmpty(resume.awards)
                   small
                     |Awarded on: #{award.date}
 
-                p.clear-margin!= award.summary
+                .mop-wrapper!= award.summary
diff --git a/jade/background/education.jade b/jade/background/education.jade
@@ -8,7 +8,7 @@ unless _.isEmpty(resume.education)
       h4.title.text-uppercase Education
 
       .content
-        ul.list-unstyled
+        ul.list-unstyled.clear-margin
           - each education_info in resume.education
             li.card.card-nested
               .content
@@ -24,7 +24,7 @@ unless _.isEmpty(resume.education)
                     |#{education_info.area}, #{education_info.studyType},&nbsp;
                   |#{education_info.institution}
 
-                p.text-muted
+                p.text-muted(class=!education_info.gpa && _.isEmpty(education_info.courses) ? 'clear-margin' : '')
                   small
                     |#{education_info.startDate} - #{education_info.endDate || 'Present'}
                 i= education_info.gpa

diff --git a/jade/background/interests.jade b/jade/background/interests.jade
@@ -8,7 +8,7 @@ unless _.isEmpty(resume.interests)
       h4.title.text-uppercase Interests
 
       .content
-        ul.list-unstyled
+        ul.list-unstyled.clear-margin
           - each interest in resume.interests
             li.card.card-nested
               p

diff --git a/jade/background/publications.jade b/jade/background/publications.jade
@@ -9,7 +9,7 @@ unless _.isEmpty(resume.publications)
       h4.title.text-uppercase Publications
 
       .content
-        ul.list-unstyled
+        ul.list-unstyled.clear-margin
           - each publication in resume.publications
             li.card.card-nested
               .content
@@ -25,4 +25,4 @@ unless _.isEmpty(resume.publications)
                 p.text-muted
                   small= 'Published on: ' + publication.releaseDate
 
-                p.clear-margin!= publication.summary
+                .mop-wrapper!= publication.summary
diff --git a/jade/background/references.jade b/jade/background/references.jade
@@ -8,7 +8,7 @@ unless _.isEmpty(resume.references)
       h4.title.text-uppercase References
 
       .content
-        ul.list-unstyled
+        ul.list-unstyled.clear-margin
           - each reference_info in resume.references
             li.card.card-nested
               if reference_info.website
@@ -17,4 +17,4 @@ unless _.isEmpty(resume.references)
                 |#{reference_info.name}
 
               blockquote.quote
-                p.clear-margin!= reference_info.reference
+                .mop-wrapper!= reference_info.reference
diff --git a/jade/background/skills.jade b/jade/background/skills.jade
@@ -8,7 +8,7 @@ unless _.isEmpty(resume.skills)
       h4.title.text-uppercase Skills
 
       .content
-        ul.list-unstyled
+        ul.list-unstyled.clear-margin
           - each skill in resume.skills
             li.card.card-nested.card-skills
               if skill.display_progress_bar

diff --git a/jade/background/volunteer-work.jade b/jade/background/volunteer-work.jade
@@ -8,7 +8,7 @@ unless _.isEmpty(resume.volunteer)
       h4.title.text-uppercase Volunteer Work
 
       .content
-        ul.list-unstyled
+        ul.list-unstyled.clear-margin
           - each volunteer_info in resume.volunteer
             li.card.card-nested
               .content
@@ -30,7 +30,7 @@ unless _.isEmpty(resume.volunteer)
                   small
                     |#{volunteer_info.startDate} - #{volunteer_info.endDate || 'Present'}
 
-                p!= volunteer_info.summary
+                .mop-wrapper!= volunteer_info.summary
 
                 unless _.isEmpty(volunteer_info.highlights)
                   ul

diff --git a/jade/background/work-experience.jade b/jade/background/work-experience.jade
@@ -7,7 +7,7 @@ unless _.isEmpty(resume.work)
     .info
       h4.title.text-uppercase Work Experience
 
-      ul.list-unstyled
+      ul.list-unstyled.clear-margin
         - each experience in resume.work
           li.card.card-nested.clearfix
             .content
@@ -35,7 +35,7 @@ unless _.isEmpty(resume.work)
                       i.icon-clock.mr-5
                       |#{experience.duration}
 
-              p!= experience.summary
+              .mop-wrapper.space-bottom!= experience.summary
 
               unless _.isEmpty(experience.highlights)
                 ul