chore: golangci-lint 升级，修复新检查出的错误

.golangci.yml

@@ -3,6 +3,7 @@ linters:
     disable:
 # 因为只有两行语句的 case 语句里面强制要求 return 语句换行会让整个 switch 很分裂。
         - wsl
+        - nlreturn
 # 因为连 1 都算 magic number 的话，许多循环就没法写了。
 # https://github.com/tommy-muehle/go-mnd/issues/3
         - gomnd
@@ -14,11 +15,17 @@ linters:
 # 有些情况下错误不可避免：
 # https://github.com/mvdan/unparam/issues/43
         - unparam
-# 下面这两个 checker 太过激进，并不认同
+# 下面这两个 checker 太过激进，并不认同。
         - gochecknoglobals
         - gochecknoinits
+# godot 要求注释必须以句号结尾，然而并不支持中文句号，放弃。
+        - godot
 
 linters-settings:
     errcheck:
         check-type-assertions: true
         ignore: '[FS]?[Pp]rint(|f|ln)|Write'
+    exhaustive:
+        default-signifies-exhaustive: true
+    gci:
+        local-prefixes: github.com/mudclient/go-mud

lua-api/lua.go

@@ -14,6 +14,8 @@ import (
 	lua "github.com/yuin/gopher-lua"
 )
 
+var errPanic = errors.New("LUA Panic")
+
 type Config struct {
 	Enable bool   `flag:"|true|是否加载 Lua 机器人"`
 	Path   string `flag:"p|lua|Lua 插件路径 {path}"`
@@ -91,7 +93,7 @@ func (api *API) Reload() error {
 	l.SetGlobal("DelMSTimer", l.NewFunction(api.LuaDelTimer))
 
 	l.Panic = func(*lua.LState) {
-		api.Panic(errors.New("LUA Panic"))
+		api.Panic(errPanic)
 	}
 
 	if err := l.DoFile(mainFile); err != nil {

main.go

@@ -8,16 +8,16 @@ import (
 	"strings"
 	"time"
 
-	"github.com/mudclient/go-mud/app"
-	"github.com/mudclient/go-mud/lua-api"
-	"github.com/mudclient/go-mud/mud"
-	"github.com/mudclient/go-mud/ui"
-
 	"github.com/flw-cn/go-smartConfig"
 	"github.com/mattn/go-runewidth"
 	"github.com/rivo/tview"
 	"github.com/spf13/cobra"
 	"golang.org/x/text/width"
+
+	"github.com/mudclient/go-mud/app"
+	"github.com/mudclient/go-mud/lua-api"
+	"github.com/mudclient/go-mud/mud"
+	"github.com/mudclient/go-mud/ui"
 )
 
 type ClientConfig struct {
@@ -83,8 +83,8 @@ LOOP:
 				plainLine := ansiRe.ReplaceAllString(rawLine, "")
 				if c.debug {
 					line := showLine
-					line = strings.Replace(line, "\x1b[", "<OSI>", -1)
-					line = strings.Replace(line, "\t", "<TAB>", -1)
+					line = strings.ReplaceAll(line, "\x1b[", "<OSI>")
+					line = strings.ReplaceAll(line, "\t", "<TAB>")
 					c.ui.Println(line)
 					line = tview.TranslateANSI(showLine)
 					line = tview.Escape(line)

mud/iac.go

@@ -213,6 +213,7 @@ func (iac IACMessage) String() string {
 		codeName[iac.Args[0]] != "" {
 		argName = codeName[iac.Args[0]]
 	}
+
 	return fmt.Sprintf("IAC %s %s", cmdName, argName)
 }
 
@@ -224,7 +225,7 @@ func (iac IACMessage) Eq(command byte, args ...byte) bool {
 	return bytes.Equal(iac.Args, args)
 }
 
-func (iac *IACMessage) Scan(b byte) bool {
+func (iac *IACMessage) Scan(b byte) (completed bool) {
 	switch iac.state {
 	case stCmd:
 		switch b {

mud/mud.go

@@ -9,7 +9,6 @@ import (
 	"time"
 
 	"github.com/flw-cn/printer"
-
 	"golang.org/x/text/encoding"
 	"golang.org/x/text/encoding/simplifiedchinese"
 	"golang.org/x/text/encoding/traditionalchinese"

mud/scan.go

@@ -18,7 +18,9 @@ type CSIMessage struct {
 }
 
 type Line struct{ *bytes.Buffer }
+
 type IncompleteLine struct{ *bytes.Buffer }
+
 type EOF bool
 
 func (CSIMessage) IsMessage()     {}
@@ -88,6 +90,7 @@ func (s *Scanner) Scan() Message {
 			default:
 				line.WriteByte(b)
 			}
+
 		case stIACCommand:
 			if b == IAC {
 				return *iacCmd
@@ -102,7 +105,7 @@ func (s *Scanner) Scan() Message {
 // readByte 努力读取一个字节，并返回成功(nil)或两种错误之一：
 //     timeout:    超时
 //     io.EOF:     连接已经不可用
-// 优先从 s.buf 中读取，如果 s.buf 为空，则从 s.r 中读取
+// 优先从 s.buf 中读取，如果 s.buf 为空，则从 s.r 中读取。
 func (s *Scanner) readByte() (byte, error) {
 	b, err := s.buf.ReadByte()
 	if err != io.EOF {

ui/readline.go

@@ -7,6 +7,8 @@ import (
 	"github.com/rivo/tview"
 )
 
+const defaultHistorySize = 10000
+
 type Readline struct {
 	*tview.InputField
 
@@ -23,19 +25,17 @@ func NewReadline() *Readline {
 		InputField:  tview.NewInputField(),
 		history:     make([]string, 0, 32),
 		curSel:      0,
-		historySize: 10000,
+		historySize: defaultHistorySize,
 	}
 }
 
 func (r *Readline) SetRepeat(b bool) *Readline {
 	r.repeat = b
-
 	return r
 }
 
 func (r *Readline) SetAutoTrim(b bool) *Readline {
 	r.autoTrim = b
-
 	return r
 }