Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

Add test suite #11

Closed
rogersm opened this issue Jan 31, 2018 · 4 comments · Fixed by #17
Closed

Add test suite #11

rogersm opened this issue Jan 31, 2018 · 4 comments · Fixed by #17
Labels
enhancement New feature or request

Comments

@rogersm
Copy link
Contributor

rogersm commented Jan 31, 2018

Now that we have Travis CI integration, we need a test suit. I propose to use Check.

It's small, easy to use, and documented.

Are we ok to move to Check or do you prefer something different?
@rogersm rogersm added the enhancement New feature or request label Jan 31, 2018
@zachflower
Copy link
Member

It looks like it can be installed on basically any system, so I'm down with it. How does it compare with CUnit?

@rogersm
Copy link
Contributor Author

rogersm commented Jan 31, 2018

Check has some additional functionality, like fixtures, but both have a lot in common. Happy to use CUnit if the team is more confortable with CUnit.

By the way, Check (and CUnit) are LPGL... this should not clash with guildmud MIT license, but are we ok to use LGPL?

@zachflower
Copy link
Member

As far as I know LGPL doesn't conflict with our MIT license, but if anyone has a more informed opinion than mine I welcome it.

@rogersm
Copy link
Contributor Author

rogersm commented Feb 1, 2018

No, it does not conflict with MIT license.

One final question before submitting the PR, is check available in Vagrant? or is there anything easier to deploy?

@rogersm rogersm mentioned this issue Feb 5, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add testing infrastructure
2 participants
@rogersm @zachflower