[EGD-7251] Fix transparent backgrounds in PlantUML #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekidd
approved these changes
Aug 2, 2021
SP2FET
approved these changes
Aug 2, 2021
|
please squash the commits and update the branch to the master :) |
wojtekidd
changed the title
|
Hi, please, update the branch to the master branch - we'll be trying to run the CI checks for this PR and merge it afterward :) |
Images generated using PlantUML had transparent backgrounds which made their text difficult to read on GitHub when using "Dark Mode". Forcing a background color of #F0F0F0 ensures they are all readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images generated using PlantUML had transparent backgrounds which made
their text difficult to read on GitHub when using "Dark Mode". Forcing
a background color of #F0F0F0 ensures they are all readable.
The secondary commit is all the regenerated images.