Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron builder #150

Merged
merged 2 commits into from Mar 11, 2021
Merged

Update electron builder #150

merged 2 commits into from Mar 11, 2021

Conversation

staszewski
Copy link
Contributor

@staszewski staszewski commented Mar 10, 2021

Jira: [PDA-XXX]

Description

I had this error Error: Exit code: 1. Command failed: hdiutil unflatten while building the app. I went away when I updated electron-builder to newest version.

electron-userland/electron-builder#5424 (comment)

Screenshots // put images here

Self check

  • Self CR'd
  • Tests included
  • Description and screenshots attached

PR Status

  • Code Review
  • Quality Assurance

Blockers

Deploy Notes

Copy link
Member

@dkarski dkarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app build went successfully on my mac 👍

@dkarski
Copy link
Member

dkarski commented Mar 11, 2021

@staszewski merge? 🤔

@staszewski staszewski merged commit 75d1587 into master Mar 11, 2021
@staszewski staszewski deleted the update-builder branch March 11, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants