[CP-2720] Modal refactor (dot notation) #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs/generic-view/ui/src/lib/predefined/import-contacts/import-contacts-list.tsx
dkarski
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
I've encountered dot notation before, often misused or overdone. Here, I believe this convention fits perfectly for a component that defines a domain-specific group of sub-components you can utilize.
This approach reduces the number of imports and enhances the readability of the component and its custom derivatives.
Great job on this implementation!
❤️ ❤️ ❤️
libs/generic-view/ui/src/lib/interactive/modal/helpers/modal-size-controller.tsx
Show resolved
Hide resolved
Base automatically changed from
CP-2707-contacts-import-ui
to
CP-2595-selecting
April 16, 2024 12:42
# Conflicts: # libs/generic-view/ui/src/lib/interactive/form/input/search-input.tsx # libs/generic-view/ui/src/lib/interactive/interactive.ts # libs/generic-view/ui/src/lib/predefined/backup-restore/backup-restore-error.tsx # libs/generic-view/ui/src/lib/predefined/backup-restore/backup-restore.tsx # libs/generic-view/ui/src/lib/predefined/backup/backup-error.tsx # libs/generic-view/ui/src/lib/predefined/import-contacts/import-contacts-error.tsx # libs/generic-view/ui/src/lib/predefined/import-contacts/import-contacts-list.tsx # libs/generic-view/ui/src/lib/predefined/import-contacts/import-contacts-progress.tsx # libs/generic-view/ui/src/lib/predefined/import-contacts/import-contacts-success.tsx # libs/generic-view/ui/src/lib/predefined/import-contacts/import-contacts.tsx
dkarski
pushed a commit
that referenced
this pull request
May 23, 2024
Co-authored-by: Łukasz Kowalczyk <freelancer.lukasz.kowalczyk@gmail.com> Co-authored-by: Łukasz Kowalczyk <37898730+lkowalczyk87@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Reference: CP-2720
📝 Description ️
💪 Checklist before requesting a review - nice to have
❗ Checklist before merging a pull request