Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backend/cpp/llama CMakeList.txt on OSX #1212

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Fix backend/cpp/llama CMakeList.txt on OSX #1212

merged 3 commits into from
Oct 25, 2023

Conversation

dave-gray101
Copy link
Collaborator

  • detect OSX and use the directories associated with homebrew-installed libraries
  • Tiny logging change makes it easier to detect Protobuf issues, was helpful while creating this so I'm keeping it in place

mudler
mudler approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@mudler mudler merged commit b839eb8 into mudler:master Oct 25, 2023
8 of 9 checks passed
@mudler mudler added the bug Something isn't working label Oct 30, 2023
@dave-gray101 dave-gray101 deleted the fix-osx-backend-cpp-llama-cmake-homebrew branch February 21, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dave-gray101 @mudler