Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1051: handle openai presence and request penalty parameters #1817

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

blob42
Copy link
Contributor

@blob42 blob42 commented Mar 10, 2024

  • request debugging: disable marshalling of context fields
  • merging FrequencyPenalty request param with config

Description

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit cb2539c
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/65ee42597d350c00083a6b2b
😎 Deploy Preview https://deploy-preview-1817--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mudler
mudler previously approved these changes Mar 10, 2024
@blob42 blob42 force-pushed the api-fixes branch 2 times, most recently from f0f7f17 to 72a4585 Compare March 10, 2024 22:20
@blob42
Copy link
Contributor Author

blob42 commented Mar 10, 2024

@mudler please do not merge yet, I noticed that PresencePenalty is not handled on the API side but is present in llama backend. I will try to add it as well

@mudler
Copy link
Owner

mudler commented Mar 10, 2024

@blob42 mind also about merge conflicts - this can't be merged until rebased on master

Signed-off-by: blob42 <contact@blob42.xyz>
Signed-off-by: blob42 <contact@blob42.xyz>
Signed-off-by: blob42 <contact@blob42.xyz>
@blob42 blob42 changed the title fixes #1051: properly merge frequency_penalty request parm with config fixes #1051: handle openai presence and request penalty parameters Mar 10, 2024
@blob42
Copy link
Contributor Author

blob42 commented Mar 17, 2024

@mudler I am done with modifications on this PR, let me know if I should add something in the docs or tests

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks!

@mudler mudler merged commit 801b481 into mudler:master Mar 17, 2024
20 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Mar 19, 2024
…0.1 by renovate (#19487)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) |
patch | `v2.10.0-cublas-cuda11-ffmpeg-core` ->
`v2.10.1-cublas-cuda11-ffmpeg-core` |
| [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) |
patch | `v2.10.0-cublas-cuda11-core` -> `v2.10.1-cublas-cuda11-core` |
| [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) |
patch | `v2.10.0-cublas-cuda12-ffmpeg-core` ->
`v2.10.1-cublas-cuda12-ffmpeg-core` |
| [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) |
patch | `v2.10.0-cublas-cuda12-core` -> `v2.10.1-cublas-cuda12-core` |
| [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) |
patch | `v2.10.0-ffmpeg-core` -> `v2.10.1-ffmpeg-core` |
| [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) |
patch | `v2.10.0` -> `v2.10.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>mudler/LocalAI (docker.io/localai/localai)</summary>

###
[`v2.10.1`](https://togithub.com/mudler/LocalAI/releases/tag/v2.10.1)

[Compare
Source](https://togithub.com/mudler/LocalAI/compare/v2.10.0...v2.10.1)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

##### What's Changed

##### Bug fixes 🐛

- fix(llama.cpp): fix eos without cache by
[@&#8203;mudler](https://togithub.com/mudler) in
[mudler/LocalAI#1852
- fix(config): default to debug=false if not set by
[@&#8203;mudler](https://togithub.com/mudler) in
[mudler/LocalAI#1853
- fix(config-watcher): start only if config-directory exists by
[@&#8203;mudler](https://togithub.com/mudler) in
[mudler/LocalAI#1854

##### Exciting New Features 🎉

- deps(whisper.cpp): update, fix cublas build by
[@&#8203;mudler](https://togithub.com/mudler) in
[mudler/LocalAI#1846

##### Other Changes

- fixes [#&#8203;1051](https://togithub.com/mudler/LocalAI/issues/1051):
handle openai presence and request penalty parameters by
[@&#8203;blob42](https://togithub.com/blob42) in
[mudler/LocalAI#1817
- fix(make): allow to parallelize jobs by
[@&#8203;cryptk](https://togithub.com/cryptk) in
[mudler/LocalAI#1845
- fix(go-llama): use llama-cpp as default by
[@&#8203;mudler](https://togithub.com/mudler) in
[mudler/LocalAI#1849
- ⬆️ Update docs version mudler/LocalAI by
[@&#8203;localai-bot](https://togithub.com/localai-bot) in
[mudler/LocalAI#1847
- ⬆️ Update ggerganov/llama.cpp by
[@&#8203;localai-bot](https://togithub.com/localai-bot) in
[mudler/LocalAI#1848
- test/fix: OSX Test Repair by
[@&#8203;dave-gray101](https://togithub.com/dave-gray101) in
[mudler/LocalAI#1843

**Full Changelog**:
mudler/LocalAI@v2.10.0...v2.10.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI1Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frequency_penalty and presence_penalty from curl request discarded
2 participants