feat: cancel stream generation if client disappears #792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added
Context
andCancel
fields toOpenAIRequest
, and then ensured that the new per-request context was wired up to the grpc client.Now if I ctrl+c my curl request while its streaming, the LocalAI server will show:
Notes for Reviewers
The next request after a cancellation is acting weird and produces some garbage tokens.
The third request will spin up the backend again and that works. Until another request is cancelled anyway.
Signed commits