Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind luet util {unpack, *} cli arguments to viper to be settable via config file and environment variables. #346

Open
pocketbroadcast opened this issue Dec 6, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pocketbroadcast
Copy link

Is your feature request related to a problem? Please describe.

Many tools support docker/config file to set authentication for private registries.
Luet has --auth-username and --auth-password besides other cli arguments to set such.
Unfortunately, in some cases (to be specific Auroraboot) these cli args cannot be set directly!

Describe the solution you'd like

Bind the cli args (cobra.Command.Flags) to config file or environment variables (viper.BindPFlag)
That way, one could override these by setting appropriate environment variables.

Describe alternatives you've considered

An alternative was to follow the approach of other tools and support for docker config to read in authentication for registries.

Additional context

For now the proposed enhancement works for me and I was happy to contribute my changes
Feel free to comment any alternatives, additional views on that!

@pocketbroadcast pocketbroadcast added the enhancement New feature or request label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants