Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Option to Remove Potentially Sensitive Content from Settings Packs for the Marketplace Automatically #320

Closed
RooRay opened this issue Nov 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@RooRay
Copy link

RooRay commented Nov 15, 2022

Description

Add an option to remove potentially sensitive information (such as name, birthday, location for weather) when importing your Mue config to use for Marketplace Settings Packs to not leak said information accidentally.

Expected behaviour

Remove/reset settings such as location, birthday, greetingName and others to their default values or blank when the option is selected.

Design
I promise I've used Figma before now 😭

https://www.figma.com/file/nupK2oBRka6M8PV6Nl3BQv/Mue-Remove-Personal-Info-Idea

image

@RooRay RooRay added the enhancement New feature or request label Nov 15, 2022
davidcralph added a commit that referenced this issue Nov 26, 2022
@davidcralph
Copy link
Member

Fixed in 7.0

@RooRay
Copy link
Author

RooRay commented Nov 26, 2022

luv u big man david

davidcralph added a commit that referenced this issue Jan 8, 2023
* feat: add work in progress 7.0 code

Co-authored-by: Alex Sparkes <turbomarshmello@gmail.com>

* chore: add notice

* fix: add missing alias to webpack config

* Added floating UI to package.json

* fix: modal navbar

* fix: port welcome modal fix from 6.0.5
Co-authored-by: David Ralph <me@davidcralph.co.uk>

* feat: about, remove redundancy
- Remove redundant background option
- about tab UI improvements
- improve widget order UI.. to be completed later

* feat: update slider + create
- got rid of commented out css
- update about tab UI
- add reset icon to reset text
- change link colour
- add number to show value on slider
- reorder greeting settings to make a bit more sense

* fix: author loading before quote
- Make author div not load if quote is empty
- photoinformation taking too much of the screen
- more transitions and consistent transitions
- running prettier across all files

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: various fixes, add microphone active border etc

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: various fixes, add microphone active border etc

* fix: slider text, quote
- Quote was being irritating on lower resolutions and would make it so the text for author would go outside
- Text on slider was getting jammed together

* build: replace webpack with vite (WIP)

* feat: Reminder settings UI

* feat: pomodoro UI + general changes
- Remove settingsitem line at end
- Convert more divs to settingsitem
- Pomodoro Settings
- Add more descriptions
- Changes loaders

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* build: add stylelint

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* refactor: cleanup and remove unused stuff

* fix: marketplace quote images, offline background img and quotes, remove placeholder text

* fix: vite extension build, add source to photo info

* fix: welcome modal bugs, about tab issues

* fix: offline mode fixes, about tab fix, update modal text

* feat: rolling out share modal for photoinfo

* fix: fix markeplace item grid

* feat: custom background drag and drop, error reporting, better ui, new settings, fixes

* fix: add link modal, marketplace

- Addons title
- icon for check for updates
- update add link modal
- improve the style of the smaller modals
- Link back to create tab on marketplace

* fix: welcome modal size

* feat: upload image compression, todo drag and drop, fixes

Co-authored-by: Alex Sparkes <turbomarshmello@gmail.com>

* fix: various modal tab fixes and changes, reorder some settings, fix marketplace

* feat: install multiple quote packs in marketplace etc (WIP)

* feat: info tooltip

* fix:  todo ordering
- start work on improving loaders, error messages etc

* fix: build problem try 1

* fix: attempt 2

* feat: improve navigability of complex settings
-  start work on reducing popin of certain elements

* feat: add data section to advanced with sync

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* chore: improve background back btn, update dependencies

* feat: add custom changes to drag and drop, refactor search, comments, video upload check (untested)

* fix: photo info share modal, navbar, remove unused code

* fix: sidebar bug, tab name translation

* feat: weather sizing, achievements

* feat: consistent header for sub sections
- fixed achievements grid
- added more achievements
- altered achievements style
- made header of background subsection consistent with advanced

* feat(translations): first half of 7.0 translation support

* feat(translations): add 7.0 support for most settings and some of marketplace

* feat(translations): bug fixes, more 7.0 support

* fix: background upload, finish 7.0 translation support

* fix(translations): modal error fixes

* feat: background settings improvements

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* Turkish_Language_Support_Added (#285)

* Turkish_Language_Support_Added

The necessary files were updated with the Turkish translation file.

* Word_Corrections

* fix: overflow of custom images + visual

* fix: change start command

* fix: create tab

* fix: various modal fixes and improvements

Co-authored-by: Alex Sparkes <turbomarshmello@gmail.com>

* fix: consistency across tabs

* fix: add missing updated code from live share

* fix: quote skeleton

* feat: redo of message UI & widget order experiment

* fix: sideload tab and file uploads

* feat: make overview tab use actual elements

* feat: achievements system works

* fix: custom search engine settings, marketplace translation

* Grammar_and_Simplification_for_Turkish_Language (#290)

* Turkish_Language_Support_Added

The necessary files were updated with the Turkish translation file.

* Word_Corrections

* Turkish_Simplification_and_Editing

* Update_tr_TR

Letter Layout for Interface Compatibility

* Last_Check_tr_TR

It looks good for now.

Co-authored-by: David Ralph <ohlookitsderpy@protonmail.com>

* feat: new collection design, improvements

Co-authored-by: David Ralph <me@davidcralph.co.uk>
Co-authored-by: Isaac <contact@eartharoid.me>

* Fix: marketplace fixes

Co-authored-by: Isaac <contact@eartharoid.me>

* fix: collection gradient

* feat: marketplace item page experimentation

* fix: item page carousel

* fix: marketplace QoL

* feat: get collection data from api

* fix: my add-ons tab, remove unused code

* chore(deps): update package.json

* fix: commence work on welcome modal

* fix: welcome modal scroll problem on lower res

* feat: welcome modal first page redesign

* feat: clock changes

* feat: vertical clock

* fix: rename to vertical clock

* fix: lazy repair of the share modal

* feat: collection news alt

* fix: remove unused code, change Turkish name

* fix: message length

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: overview tab

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: various fixes and improvements

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: various welcome modal fixes
- fix links
- fix style choice
- change how theme selector works

* fix: weather

* polish

* fix: message

* fix: minor fixes and cleanup

* feat(translations): support for new strings

* fix: use localised wikipedia for api, remove unused icons

* Remove photo info width

* Update PhotoInformation.jsx

* fix: weather bug

* fix: addons not being uninstalled correctly

* fix: quote showing icon from incorrect quote pack

* fix: lil photo info bug

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* refactor: cleanup various files

* refactor: clean translation system and more widget stuff

* fix(translations): fix issues caused by refactor

* perf: experimental upgrade to deps and fix esbuild warnings

* fix: weather

* fix: icon bug & small cleanup

* fix: show photoinformation setting

* chore(manifest): Upgrade to v3

Not sure if it is correct, security policy likely isn't.

* fix: add missing translations, fix birthday

* fix: translation display bug, marketplace error, cleanup carousel

* fix(translations): add missing, fix weather location

* fix: marketplace collections, weather settings

* fix: marketplace translations

* fix: cleanup code and fix weather etc

Co-authored-by: Alex Sparkes <turbomarshmello@gmail.com>

* fix: clock colour among other things

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: navbar zoom

* fix: remove unused & bugged feature

* fix: clean up some CSS

* we don't talk about underscores

* fix: interval

* overview changes

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: collection refresh and item language display

* add: type of item marketplace

* fix: search autocomplete error

* feat: missing translation

* fix: background refresh spam effects issue

* fix: various fixes

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: various fixes

* fix: experimental fix for interval

* fix: small line missed

* chore: update i18n on 7.0, fix link not opening in new tab

* fix: interval not appearing for marketplace

* fix: various fixes and remove unused code

* fix: custom quote, message, move sideload etc

* fix: update styling on custom quote settings etc

* feat(dev): add commitlint

* fix: background interval

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* feat: overhaul of quick links

* feat: search for marketplace

* fix: marketplace + more
- Fix clock zoom
- Fix 0th birthday bug
- marketplace search style
- marketplace search not sensitive to case

* fix: baidu search bug
- reported via google chrome store reviews
Co-authored-by: David Ralph <me@davidcralph.co.uk>

* fix: some quotes have newlines at the end

* fix: quote image copyright text

* feat: edit quicklink

* fix: adding links works again

* fix: missing translation on item page
- change position of close button on modal

* fix: carousel and quicklink translations

* fix: missing translations

* fix: weather tooltip

* feat: quote UI consistent with other elements

* fix: quote UI text colour

* fix: UX improvements to custom backgrounds

* fix: numerous background interval fixes

* fix: comment out code causing flash
thank you rooray

* feat: move all sideload logic to added, drag and drop upload, update deps

* fix: background marketplace interval

* fix: sideload error modal styling

Co-authored-by: David Ralph <me@davidcralph.co.uk>

* perf: major widget refactoring

* perf: use memo, fix quicklinks key err

* chore: update quicklink and autocomplete apis

* fix: marketplace undefined errors

* fix: optimise and repair marketplace

Co-authored-by: Alex Sparkes <turbomarshmello@gmail.com>

* chore: run prettier

* fix: search dropdown, missing translations, overview date

* fix: background interval bug
- took far too long

* Add Español (Latinoamérica) (#319)

* Add Español (Latinoamérica)

* Update es-419.json

* Update es-419.json

* feat: upgrade to API v2

* fix: news on overview

* feat: attempt image blur

* fix: background blur transition

* fix: quote cleanup and test

* fix: various
- temporarily comment out quote interval
- fix background transition on firefox

* fix: background transition compatibility

* fix: update API URL

* feat: don't show image again

* fix: background categories

* fix: improve category chip styling

* fix: move tooltips photo info

* fix: tooltip width photoinformation

* fix: use AVIF if supported

* fix: the previous fix (it broke non-AVIF browsers)

* fix: favouriting images

* fix: revoke the image blob

* fix: classic photo info
- plus the testing option of 10 seconds for interval

* fix: quote language settings

* fix: "Refresh Page Page" with en_US locale

* fix: don't get quote twice

* fix: allow map for Mue images

* feat: pre-fetch image data from API

so the blur hash is instantly available

* feat: pre-fetch quote data from API

* fix: don't show "N/A"

* feat: `photoMap` true by default

* feat: don't get the same image twice in a row

Works with Mue API only, not Unsplash and not photo packs.

* fix: don't get the same image twice in a row

* chore: update dependencies, change compression, remove unneeded about string

* fix: #320 by adding new ignore list

* fix: es_419 locale, run prettier, remove unused line

* fix: build error due to top level await

* fix: pnpm lock was ice cold

* fix: overview style
- driving home for christmas
- 7.0 is christmas
- that is song lyric

* fix: missing translations, create tab back button

* fix: remove placeholder string

* fix: photographers list

* fix: don't set location to "N/A"

* fix: translation bugs

* chore: update dependencies etc

* fix: start fixing photo map

* TR Translation Update (#329)

* Update tr_TR.json

TR translate file update.

* tr_TR.json File Update - Check One Vercel

* Check Translate

* Translation edit after bug fix. First review.

* , Check

* , Check

* , Check

* 330 issue fixed, translate added

Signed-off-by: Kağan Can Şit <kagancansit@hotmail.com>

* fix: typo

* feat: improve collection gradient

* feat: modernisation of modal theme colours

* fix: light theme fixes

* feat: make the marketplace look stunning

* feat: make marketplace item pages prettier

and add setting values table on pre-set settings page.

* chore: comment out broken interval feature

Signed-off-by: Kağan Can Şit <kagancansit@hotmail.com>
Signed-off-by: David Ralph <ohlookitsderpy@protonmail.com>
Co-authored-by: Alex Sparkes <turbomarshmello@gmail.com>
Co-authored-by: Kağan Can Şit <kagancansit@hotmail.com>
Co-authored-by: Isaac <contact@eartharoid.me>
Co-authored-by: Isaac <git@eartharoid.me>
Co-authored-by: alexsparkes <alexsparkes@gmail.com>
Co-authored-by: BloodDragooner2 <117775945+BloodDragooner2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants