Mixcloud bee

[Horrendus]

MixcloudBee that can follow a Mixcloud user/feed and creates an event when a new CloudCast was uploaded

As it is one of my first serious go & beehive contributions I leave it atm as WIP for review. Please also review the new dependency https://github.com/Horrendus/go-mixcloud

[muesli]

Nice work! The first thing that pops out when looking at go-mixcloud, is that you moved the actual code in a sub-dir (mixcloud) and separated the tests into their own package.

This can be done (especially if you want to write your tests like an external package user), but the common approach is to move them along side the actual code (so you would have somefile.go and somefile_test.go). That way godoc can also extract examples from your docs.

Either way, I'd recommend moving the actual code directly into the go-mixcloud directory. Each Go package is only composed of one directory, so a subdirectory tests wouldn't mess things up.

[muesli]

I also heavily recommend using gofmt and set up a hook in your IDE to automatically run it on saving a Go file. It's thoroughly good.

[Horrendus]

I think I applied all your review comments on go-mixcloud, the mixcloud bee is not yet updated (need to read about go modules :) ).

For further review of the dependency I opened this issue here: Horrendus/go-mixcloud#1

Further review of the mixcloud bee should of course still be done here once I updated it ;)

[muesli]

The good news is: Go modules doesn't change much for you right now.

Make sure to use Go 1.11+, and either set GO111MODULE=on, or compile beehive outside your $GOPATH. This will activate Go modules support. Now, if you import go-mixcloud as a dependency in your bee, Go will automatically detect that and update the go.mod file for you. Make sure to include the changes to that file in your pull request.

"The go command resolves imports by using the specific dependency module versions listed in go.mod. When it encounters an import of a package not provided by any module in go.mod, the go command automatically looks up the module containing that package and adds it to go.mod, using the latest version"

[muesli]

Looking good!

[Horrendus]

The Bee no longer sleeps, it now has an action "pollFeed" that can be triggered by e.g. a CronBee. Not fully sure if I correctly did the options part of the action (Action shouldnt have any option).

[CalmBit]

Just two tiny details that are probably largely inconsequential - otherwise, looking great!

[Horrendus]

@CalmBit: Thanks for the suggestions!

[muesli]

LGTM! Just waiting for TravisCI to finish.