fix(output): cache bg and fg colors by default #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
cach-default
branch
from
b75b48b
to
c5fed7f
Compare
caarlos0
approved these changes
Apr 14, 2023
It's uncommon for users to change the colorscheme of their terminal from a dark to light, or vice versa, while a program is running. This makes Termenv query the terminal for colors too many times. Enable color caching by default and give the program the option to opt-out using WithColorCache(false).
aymanbagabas
force-pushed
the
cach-default
branch
from
c5fed7f
to
4fa0a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's uncommon for users to change the colorscheme of their terminal from a dark to light, or vice versa, while a program is running. This makes Termenv query the terminal for colors too many times.
Enable color caching by default and give the program the option to opt-out using WithColorCache(false).