-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why not pass _location_name_ on connects and disconnects? #17
Comments
What's the difference between this and #16? |
Here the question is why not use location_name instead of consider_home and send home and not_home states, which should cause no problem at all on the Home Assistant side because that's how HA works with the more 'integrated' nmap and ping tools from itself. |
consider_home is required so devices that drop off the network temporarily are not marked as away and because this script only sends data to HA on state changes, which might be multiple hours apart. Other than that, I'm not sure how exactly consider_home and location_name and zones interact, depending on that HA might need to be patched before #16 is solvable anyway. |
Got it. I have read on the HA pages that consider_home is mainly used for iPhone. My conclusion so far with this program is:
Absolutely great. 🥂 Anyone has a different experience? |
While exploring #16 I was wondering why, when a connect or disconnect happens, the script sends a consider_home value. Why not send the location_name, home on connect, and location_name, away on disconnect.
Is there a specific reason for this to not break things?
The text was updated successfully, but these errors were encountered: