Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base62 error and add Ascii85 #6

Merged
merged 3 commits into from Nov 2, 2020
Merged

Fix base62 error and add Ascii85 #6

merged 3 commits into from Nov 2, 2020

Conversation

klassiker
Copy link
Contributor

This fixes #4 (comment) by replacing base-62 with pybase62. Uninstalling the old dependency before installing the new dependency is required.

It also adds support for Ascii85 encoding.

mufeedvh
mufeedvh approved these changes Nov 2, 2020
View reviewed changes
Copy link
Owner

@mufeedvh mufeedvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👏❤️

Thank You for fixing this issue and adding ascii85 decoding! 🙌

@mufeedvh mufeedvh merged commit 0bd5fda into mufeedvh:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mufeedvh mufeedvh mufeedvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base62 decoding not working
2 participants
@klassiker @mufeedvh